diff options
| author | Nicolas Boichat <drinkcat@google.com> | 2017-04-13 09:32:22 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-04-15 04:08:07 -0700 |
| commit | 2b460c9830670070152a4509ab38b24aa80ed304 (patch) | |
| tree | 8b5691b01c6bd23eec510861df344ff73f1d866d /include/update_fw.h | |
| parent | 2f5e46cef48ec0671fd014bbdb38b060339db998 (diff) | |
| download | chrome-ec-2b460c9830670070152a4509ab38b24aa80ed304.tar.gz | |
common/update_fw: Remove board-specific rw_sections
rw_sections is defined in the exact same way on all common code
boards, let's remove it, and hard-code the values in update_fw.c
instead.
Take this as an opportunity to fold set_valid_section in
fw_update_start (this will be useful later on, as we also
want to return the inactive region version).
BRANCH=none
BUG=b:35587171
TEST=make buildall -j
TEST=Can update hammer over USB using usb_updater2
Change-Id: I4dd3224f17f89c1851c379255f1195dc54528b3d
Reviewed-on: https://chromium-review.googlesource.com/476451
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'include/update_fw.h')
| -rw-r--r-- | include/update_fw.h | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/include/update_fw.h b/include/update_fw.h index 8f7148f6ed..09d72e19d1 100644 --- a/include/update_fw.h +++ b/include/update_fw.h @@ -149,23 +149,4 @@ enum { */ #define UPDATE_PDU_SIZE 1024 -/* TODO(b/36375666): The structures below might not belong in this file. */ - -/* - * This array defines possible sections available for the firmare update. - * The section which does not map the current execting code is picked as the - * valid update area. The values are offsets into the flash space. - * - * This should be defined in board.c, with each entry containing: - * {CONFIG_RW_MEM_OFF, CONFIG_RW_MEM_OFF + CONFIG_RW_SIZE} - * for its relevant section. - */ -struct section_descriptor { - uint32_t sect_base_offset; - uint32_t sect_top_offset; -}; - -extern const struct section_descriptor * const rw_sections; -extern const int num_rw_sections; - #endif /* ! __CROS_EC_UPDATE_FW_H */ |