diff options
| author | Denis Brockus <dbrockus@google.com> | 2020-06-15 13:06:02 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-24 03:05:08 +0000 |
| commit | d47f042299bef709899ad60d4b2cf18b54a42604 (patch) | |
| tree | 2002408165077ab414b762cb9b53b717e3e8a570 /include/usb_pd_tcpm.h | |
| parent | 0fd827f7df34010375837bdf219c5f9da2e9013d (diff) | |
| download | chrome-ec-d47f042299bef709899ad60d4b2cf18b54a42604.tar.gz | |
tcpmv2: only enable AutoDischargeDisconnect when attached
Connecting a non-PD charger the DUT performs a TRY
switch to become SRC. During this TRY path the
AutoDischargeDisconnect had been enabled and the
fact the non-PD charger will never allow Vbus to
drop to Safe0V causes the fault.
AutoDischargeDisconnect should only be enabled
when there is a known stable attach and when
this stops being the case the feature should
return back to disabled.
Verified on Trembyle NCT3807 platform
BUG=b:158751942
BRANCH=none
TEST=verify try does not fault on 5V charger
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I9ab507a1bbc5b84948620b6174f946f07befde90
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2250092
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'include/usb_pd_tcpm.h')
| -rw-r--r-- | include/usb_pd_tcpm.h | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index 0816149464..9cfc1c9908 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -328,26 +328,6 @@ struct tcpm_drv { void (*tcpc_enable_auto_discharge_disconnect)(int port, int enable); - /** - * Set connection - * If this is a disconnect, set the ROLE_CONTROL, otherwise - * this is a new connection. May have to handle differently - * if we were performing auto-toggle. Allow a driver to do - * any work required to leave the unattached auto-toggle mode - * as well as setting the CC lines. If auto-toggle is not - * being used or was not the cause of the new connection - * detection then set both CC lines to the passed pull. - * - * @param port Type-C port number - * @param pull enum tcpc_cc_pull of CC lines - * @param connect Connect(1) or Disconnect(0) - * - * @return EC_SUCCESS or error - */ - int (*set_connection)(int port, - enum tcpc_cc_pull pull, - int connect); - #ifdef CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE /** * Enable TCPC auto DRP toggling. |