summaryrefslogtreecommitdiff
path: root/include/usb_pd_tcpm.h
diff options
context:
space:
mode:
authorDenis Brockus <dbrockus@chromium.org>2020-02-13 08:05:34 -0700
committerCommit Bot <commit-bot@chromium.org>2020-02-15 02:12:57 +0000
commit139e94729bc55c6dbf838d1136c04b7ce711c48f (patch)
tree705c73cdeac1a4106a32e1243c30dc92ffb79902 /include/usb_pd_tcpm.h
parent58bd6e33611249d3e40260aa7aecc29900a69cea (diff)
downloadchrome-ec-139e94729bc55c6dbf838d1136c04b7ce711c48f.tar.gz
nct38xx: auto-toggle exit cleanup
Don't set the polarity behind the back of the PD stack. Just clear the DRP and leave the CC lines so they look just as we found them. This will allow TRY to work and we will no go OPEN because we set the CC lines to something that was not expected. BUG=b:149415919 BRANCH=none TEST=verify USB-C connections are working Change-Id: I766514bd46922000ea8916d61d00265e7e5e4fd4 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2053461 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'include/usb_pd_tcpm.h')
-rw-r--r--include/usb_pd_tcpm.h24
1 files changed, 12 insertions, 12 deletions
diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h
index 9c9753ad90..d0953ab74e 100644
--- a/include/usb_pd_tcpm.h
+++ b/include/usb_pd_tcpm.h
@@ -327,6 +327,15 @@ struct tcpm_drv {
#ifdef CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE
/**
+ * Enable TCPC auto DRP toggling.
+ *
+ * @param port Type-C port number
+ *
+ * @return EC_SUCCESS or error
+ */
+ int (*drp_toggle)(int port);
+
+ /**
* Auto Toggle Connection
* There is a connection while performing auto-toggle.
* Allow a driver to do any work required to leave the
@@ -336,18 +345,9 @@ struct tcpm_drv {
* @param cc1 enum tcpc_cc_pull of CC1
* @param cc2 enum tcpc_cc_pull of CC2
*/
- void (*tcpc_auto_toggle_connection)(int port,
- enum tcpc_cc_voltage_status cc1,
- enum tcpc_cc_voltage_status cc2);
-
- /**
- * Enable TCPC auto DRP toggling.
- *
- * @param port Type-C port number
- *
- * @return EC_SUCCESS or error
- */
- int (*drp_toggle)(int port);
+ void (*drp_toggle_connection)(int port,
+ enum tcpc_cc_voltage_status cc1,
+ enum tcpc_cc_voltage_status cc2);
#endif
/**