diff options
| author | Aseda Aboagye <aaboagye@chromium.org> | 2020-03-25 23:43:12 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-26 02:49:58 +0000 |
| commit | 383b6c51874e61d9a3dd637f477a67af33e51340 (patch) | |
| tree | a67b49316c10d31d6bfe3588b1db73f8a756332b /include/usb_pd_tcpm.h | |
| parent | eb6401aa2ccf38afadc1fc2978cbd2a6d9a7c4ce (diff) | |
| download | chrome-ec-383b6c51874e61d9a3dd637f477a67af33e51340.tar.gz | |
Revert "tcpmv2: cleanup auto discharge disconnect"
This reverts commit 03f5a8686a6a2274c176ead7fb928571a3e7c1f5.
Reason for revert: This is causing chargers to not work in one
orientation with the RAA489000 used on waddledoo.
BUG=b:152444591
Original change's description:
> tcpmv2: cleanup auto discharge disconnect
>
> This CL is based on the inability to boot trembyle when a
> battery is not connected. The failure looks like it is always
> right after AutoDischargeDisconnect has been set. I asked
> Nuvoton if we could go back to using ForcedDischarge and
> veer away from AutoDischargeDisconnect and I was told no
> that it is now required.
>
> My first step was to determine how close the existing
> AutoDischargeDisconnect was to the spec and found enough
> difference that I wanted to get that in line before
> trying to pinpoint the issues causing this problem.
>
> BUG=none
> BRANCH=none
> TEST=get tcpmv2 to work without a battery attached
>
> Signed-off-by: Denis Brockus <dbrockus@google.com>
> Change-Id: I44b86ae5dfcf6b547c742c1af0228a0ed8e3520d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2105935
> Tested-by: Denis Brockus <dbrockus@chromium.org>
> Reviewed-by: Edward Hill <ecgh@chromium.org>
> Reviewed-by: Keith Short <keithshort@chromium.org>
> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
> Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Bug: none
Change-Id: Id2afdeb8d48d044a0a94277dfa0c388f864e838f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2121178
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'include/usb_pd_tcpm.h')
| -rw-r--r-- | include/usb_pd_tcpm.h | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index 35f9cccb47..4589fc4839 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -320,9 +320,8 @@ struct tcpm_drv { int enable); /** - * Set connection - * If this is a disconnect, set the ROLE_CONTROL, otherwise - * this is a new connection. May have to handle differently + * Set new connection + * There is a new connection. May have to handle differently * if we were performing auto-toggle. Allow a driver to do * any work required to leave the unattached auto-toggle mode * as well as setting the CC lines. If auto-toggle is not @@ -331,13 +330,11 @@ struct tcpm_drv { * * @param port Type-C port number * @param pull enum tcpc_cc_pull of CC lines - * @param connect Connect(1) or Disconnect(0) * * @return EC_SUCCESS or error */ - int (*set_connection)(int port, - enum tcpc_cc_pull pull, - int connect); + int (*set_new_connection)(int port, + enum tcpc_cc_pull pull); #ifdef CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE /** |