diff options
author | Jett Rink <jettrink@chromium.org> | 2020-06-16 16:20:17 -0600 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-08-06 02:06:20 +0000 |
commit | d94d4cc45e39297cd4e072a07c8fca714715fa18 (patch) | |
tree | 19873d2936d701b02c7f778ab99166115d42a08a /include/usb_pd_tcpm.h | |
parent | 17fed25d34ec92fa0c7c3bfc738e4ca63c20bba4 (diff) | |
download | chrome-ec-d94d4cc45e39297cd4e072a07c8fca714715fa18.tar.gz |
tcpmc2: fix TD.PD.LL3.E2 Retransmission test
We are retrying in both the TCPC hardware (4 total) and
in the Protocol layer (3 total) when we do not get a GoodCRC back from
the port partner. We are only suppose to retry up to nRetryCount times
which is 2. This means we should be sending 3 total replies.
Also correct a misinterpretation of the spec around SOP' and SOP"
retries. We were not retrying those packets, but we should be retry them
as the SOP. The SOP' device will not retry, but we (as the SOP) should
retry packet that we are sending to them.
The TCPM is not fast enough to meet the timing for tRetry (195 usec), so
we need to perform the retries in the TCPC hardware layer.
BRANCH=none
BUG=b:150617035
TEST=Verify passing compliance test with GRL-C2 on Trembyle
Change-Id: I55c4ab2f5ce8f64acf21af943862d96d9088622d
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2248960
Diffstat (limited to 'include/usb_pd_tcpm.h')
-rw-r--r-- | include/usb_pd_tcpm.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index b039c6f63e..bccea184e4 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -12,9 +12,6 @@ #include "ec_commands.h" #include "i2c.h" -/* Default retry count for transmitting */ -#define PD_RETRY_COUNT 3 - /* Time to wait for TCPC to complete transmit */ #define PD_T_TCPC_TX_TIMEOUT (100*MSEC) |