diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-06-09 16:53:12 -0600 |
|---|---|---|
| committer | Jett Rink <jettrink@chromium.org> | 2020-06-10 20:56:20 +0000 |
| commit | 454fda0f0c1eea8884a82f1f251e0c8cf72f65df (patch) | |
| tree | 85324883789c179ba89fc4b49d179de1b23b8a02 /include/usb_prl_sm.h | |
| parent | 1e4bc08f1da6f3066d38f5db57b27e634fdc5fc4 (diff) | |
| download | chrome-ec-454fda0f0c1eea8884a82f1f251e0c8cf72f65df.tar.gz | |
tcpmv2: clear TX_COMPLETE before starting sending
We have had issue with the TX_COMPLETE flag remaining from previous TX
transactions. This can incorrectly make the subsequent TX transaction
code think that its TX send has completed. It is safer to always clear
the TX flag before starting a new TX transition.
BRANCH=none
BUG=b:158248741
TEST=Verify that TX_SUCCESS does not linger from previous transactions
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I5fd7d849bdf97582d5b03b8d833de24b550d8c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2239034
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'include/usb_prl_sm.h')
| -rw-r--r-- | include/usb_prl_sm.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/usb_prl_sm.h b/include/usb_prl_sm.h index 58ce044f54..2d24143221 100644 --- a/include/usb_prl_sm.h +++ b/include/usb_prl_sm.h @@ -74,7 +74,6 @@ enum pd_rev_type prl_get_rev(int port, enum tcpm_transmit_type type); * @param port USB-C port number * @param type Transmit type * @param msg Control message type - * @return 0 on EC_SUCCESS, else EC_ERROR_BUSY */ void prl_send_ctrl_msg(int port, enum tcpm_transmit_type type, enum pd_ctrl_msg_type msg); @@ -85,7 +84,6 @@ void prl_send_ctrl_msg(int port, enum tcpm_transmit_type type, * @param port USB-C port number * @param type Transmit type * @param msg Data message type - * @return 0 on EC_SUCCESS, else EC_ERROR_BUSY */ void prl_send_data_msg(int port, enum tcpm_transmit_type type, enum pd_data_msg_type msg); @@ -96,7 +94,6 @@ void prl_send_data_msg(int port, enum tcpm_transmit_type type, * @param port USB-C port number * @param type Transmit type * @param msg Extended data message type - * @return 0 on EC_SUCCESS, else EC_ERROR_BUSY */ void prl_send_ext_data_msg(int port, enum tcpm_transmit_type type, enum pd_ext_msg_type msg); |