diff options
| author | Denis Brockus <dbrockus@google.com> | 2020-05-29 13:17:04 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-03 23:03:50 +0000 |
| commit | 88103a34e5b368234a463bc5f745cfa4978034b4 (patch) | |
| tree | b74b462c84abfc14c77bc8107cbf457b9169895d /include/usb_tc_sm.h | |
| parent | e0d7e156976cde28bc8bca2b1211c61759ca8995 (diff) | |
| download | chrome-ec-88103a34e5b368234a463bc5f745cfa4978034b4.tar.gz | |
TCPMv2: Aborted PR Swap should not re-enable AutoDischarge
On a recovery path exit a TCPCI I2C FAULT occurs when we
set the CC lines to open/open if AutoDischargeDisconnect
is currently enabled.
The TCPCI I2C FAULT is not a status of the I2C interface
but rather a status of the last TCPCI I2C write performed
with regards to the current state/settings of the TCPCI.
This is usually caused when AutoDischargeDisconnect is
enabled/disabled when it should not be. This change will
make sure this path will not re-enable and that entering
the recovery path will make sure AutoDischarge is disabled.
We will wait to re-enable until the TC state machine
is restarted.
BUG=b:157755939
BRANCH=none
TEST=ThinkPad Dock G2 attach should not cause FAULT-0x01
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: If70ccd90b045949e54c131512d1fb294c61dd1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2223722
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'include/usb_tc_sm.h')
| -rw-r--r-- | include/usb_tc_sm.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/usb_tc_sm.h b/include/usb_tc_sm.h index 293ed55a10..ee34e2e75e 100644 --- a/include/usb_tc_sm.h +++ b/include/usb_tc_sm.h @@ -180,8 +180,9 @@ void tc_request_power_swap(int port); * This function is called from the Policy Engine. * * @param port USB_C port number + * @param success swap completed normally */ -void tc_pr_swap_complete(int port); +void tc_pr_swap_complete(int port, bool success); /** * Informs the Type-C State Machine that a Discover Identity is in progress. |