diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-05-21 15:05:23 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-07-20 11:41:03 -0700 |
| commit | 7b504639d9b32bc292288e03143fc0404a6a8ab1 (patch) | |
| tree | 3ceb65f621cf6521902bcab3482775e645706479 /include/usbc_ppc.h | |
| parent | 5100b4c3d2059de5da41c75fc19347918eec87da (diff) | |
| download | chrome-ec-7b504639d9b32bc292288e03143fc0404a6a8ab1.tar.gz | |
ppc: remove EC ability to drive PPC GPIO
We figured out that having the EC drive the EN_SNK input of a PPC will
lead to brownout or lockout conditions since the EC will float the GPIO
when the EC reset. When the PPC input floats, the power path to the rest
of the board is cut.
If you mix this scenario with a PPC that hard-codes the over voltage
protect of vbus at 6.8V in dead battery mode, you can lock the
previously negotiated 20V Vbus out of the system until you physically
remove the USBC connection and reinsert it.
BRANCH=none
BUG=b:78896495,b:78021059,b:111545725
TEST=removing unused code. everything still works.
Change-Id: Ie9d51af766bc08e7d9b46b4610c0f84d3d0961f8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1067712
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Diffstat (limited to 'include/usbc_ppc.h')
| -rw-r--r-- | include/usbc_ppc.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/include/usbc_ppc.h b/include/usbc_ppc.h index e846a6ecca..d65fa79f0e 100644 --- a/include/usbc_ppc.h +++ b/include/usbc_ppc.h @@ -108,18 +108,9 @@ struct ppc_drv { #endif /* defined(CONFIG_USB_PD_VBUS_DETECT_PPC) */ }; - -/* PPC SNK/SRC switch control driven by EC GPIO */ -#define PPC_CFG_FLAGS_GPIO_CONTROL (1 << 0) - struct ppc_config_t { - /* Used for PPC_CFG_FLAGS_* defined above */ - uint32_t flags; int i2c_port; int i2c_addr; - /* snk|src_gpio only required if PPC_CFG_FLAGS_GPIO_CONTROL is set */ - enum gpio_signal snk_gpio; - enum gpio_signal src_gpio; const struct ppc_drv *drv; }; |