diff options
| author | Randall Spangler <rspangler@chromium.org> | 2014-02-28 14:54:05 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-03-04 06:43:24 +0000 |
| commit | 638c7d9f5df94ce977d119606555b06b41a12e71 (patch) | |
| tree | 5aa70b70fbd8cd121d0584fce04b440f3f4e5d57 /include | |
| parent | 96d0c227f0b825eecb1ede0275b99c231a17ff4e (diff) | |
| download | chrome-ec-638c7d9f5df94ce977d119606555b06b41a12e71.tar.gz | |
rambi: Remove ignored PCH signals
The EC had inputs with internal pullups on SUS_STAT#, SUSPWRDNACK, and
SLP_SX#. But we never used those signals for anything. The pullups
cost 1.5 mW power in S3. So, remove those signals and their pullups.
They can be turned back on via CONFIG_CHIPSET_DEBUG.
BUG=chrome-os-partner:25568
BRANCH=rambi
TEST=build with and without CONFIG_CHIPSET_DEBUG. Verify gpioget and
powerindebug show the signals only when it's defined.
Orig-Change-Id: I0851243615c91a3aa8aa1b28df70809b578d2e74
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/188389
Reviewed-by: Dave Parker <dparker@chromium.org>
(cherry picked from commit b805917e43ec2912404892aede64a1265201a4a4)
Change-Id: I6459bd7f544755915ac7c5f0b986a8faab1f3555
Reviewed-on: https://chromium-review.googlesource.com/188538
Commit-Queue: Randall Spangler <rspangler@chromium.org>
Tested-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Dave Parker <dparker@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/config.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/include/config.h b/include/config.h index eeada9b188..224910cce2 100644 --- a/include/config.h +++ b/include/config.h @@ -223,13 +223,16 @@ /* Compile common x86 chipset infrastructure. Required for x86 chips. */ #undef CONFIG_CHIPSET_X86 +/* Support chipset throttling */ +#undef CONFIG_CHIPSET_CAN_THROTTLE + +/* Enable additional chipset debugging */ +#undef CONFIG_CHIPSET_DEBUG + /* Support power rail control */ #define CONFIG_CHIPSET_HAS_PP1350 #define CONFIG_CHIPSET_HAS_PP5000 -/* Support chipset throttling */ -#undef CONFIG_CHIPSET_CAN_THROTTLE - /*****************************************************************************/ /* * Optional console commands |