diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2022-03-10 21:00:50 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-03-12 19:33:29 +0000 |
| commit | fe7848f4adab9b4785a60d4c9f2443f73ede789b (patch) | |
| tree | e01587a3cd798ace43d21bc23e28090d8d39f013 /include | |
| parent | 80847c63040e03bb19e0e3241387bdd9a4b9c96a (diff) | |
| download | chrome-ec-fe7848f4adab9b4785a60d4c9f2443f73ede789b.tar.gz | |
Revert "battery: Do not return display_soc if data is bad"
This reverts commit b135e45447ba42f276b6f5232e2573d166320b31.
Reason for revert: Due to its side effect. We're fixing the bug differently: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3514489/.
Original change's description:
> battery: Do not return display_soc if data is bad
>
> If BATT_FLAG_BAD_FULL_CAPACITY or BATT_FLAG_BAD_REMAINING_CAPACITY
> flags are set, then display_charge value is also bad.
> Return UNAVALIABLE error rather than 0%.
>
> BUG=b:217401040
> BRANCH=guybrush
> TEST=Force battery glitch, do not observe 0% battery in OS
>
> Change-Id: Iea861582dde1f7db3d6a4c40e88169d7f74ca159
> Signed-off-by: Rob Barnes <robbarnes@google.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3496464
> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
> Reviewed-by: Diana Z <dzigterman@chromium.org>
Cq-Depend:chromium:3514489
Bug: b:217401040
Change-Id: Ic0481d17e49ae275f7d85deed91f251e975e09d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518070
Reviewed-by: Rob Barnes <robbarnes@google.com>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/ec_commands.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/ec_commands.h b/include/ec_commands.h index ad9a53906d..68be2e17b5 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -7028,14 +7028,6 @@ struct ec_response_pchg_update { } __ec_align4; -/***************************************************************************** - * Get displayable charge percent - * - * Return - * EC_RES_SUCCESS : Values successfully read - * EC_RES_UNAVAILABLE : Values are currently unavailable, - * e.g. unresponsive battery. - */ #define EC_CMD_DISPLAY_SOC 0x0137 struct ec_response_display_soc { |