diff options
author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-04-03 11:03:23 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-08 22:30:32 -0700 |
commit | 6bd030ecd978a8b619da261510490f27f68c4e6c (patch) | |
tree | 4cd5827d1842384d477eb7f9d68c05ec7906c2ec /include | |
parent | b4cca02d9dcc5c7fa42813ae819933fd5ae9f43c (diff) | |
download | chrome-ec-6bd030ecd978a8b619da261510490f27f68c4e6c.tar.gz |
ec.tasklist: Consolidate duplicate comments
It's simply a bad idea to describe a macro in multiple locations.
It'll make it hard to change. It'll be difficult to keep all
locations in sync.
This patch replaces the comment duplicated in all ec.tasklist with
a pointer to the CONFIG_TASK_LIST definition. The macro will be
described in a single place (just like all/most other macros).
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: Id658b9d68e742e4334c692b804d9c98c8de21313
Reviewed-on: https://chromium-review.googlesource.com/1551579
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/config.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/include/config.h b/include/config.h index 89ade13c9c..0dee087d73 100644 --- a/include/config.h +++ b/include/config.h @@ -3046,16 +3046,23 @@ /* Task config */ /* - * List of enabled tasks in ascending priority order. This is normally + * List of enabled tasks in ascending priority order. This is normally * defined in each board's ec.tasklist file. * * For each task, use the macro TASK_ALWAYS(n, r, d, s) for base tasks and * TASK_NOTEST(n, r, d, s) for tasks that can be excluded in test binaries, - * where : + * where: * 'n' is the name of the task * 'r' is the main routine of the task * 'd' is an opaque parameter passed to the routine at startup * 's' is the stack size in bytes; must be a multiple of 8 + * + * Some cores use TASK_ALWAYS(n, r, d, s, f), where: + * 'f' is the bit flags for the platform specific information + * - MIA_TASK_FLAG_USE_FPU : bit 0, task uses FPU H/W + * + * For USB PD tasks, IDs must be in consecutive order and correspond to + * the port which they are for. See TASK_ID_TO_PD_PORT() macro. */ #undef CONFIG_TASK_LIST |