diff options
| author | Shawn Nematbakhsh <shawnn@chromium.org> | 2016-04-10 15:46:39 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-04-11 14:36:40 -0700 |
| commit | d2e77ddbc913a34c14e87eaa9c3104f62ec40142 (patch) | |
| tree | e03164ade39f482235da299cc432fe0b44e28885 /include | |
| parent | a3341ee7e9bf93e3757684816b8319ae726d2044 (diff) | |
| download | chrome-ec-d2e77ddbc913a34c14e87eaa9c3104f62ec40142.tar.gz | |
pd: Add config to disable PD communication in locked RO
The scheme to disable PD communication in locked RO needs to be
implemented on other platforms, so move it to common code, behind
CONFIG_USB_PD_COMM_LOCKED.
BUG=chrome-os-partner:52157
BRANCH=glados
TEST=Manual on chell. Lock system and boot to recovery, then verify PD
communication is functional. Enable CONFIG_USB_PD_COMM_LOCKED and verify
PD communication isn't functional under the same test conditions.
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I8d1f24c0b60cf1c54e329af003b7083ee55ffc40
Reviewed-on: https://chromium-review.googlesource.com/338064
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/config.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/include/config.h b/include/config.h index 8181bbb532..d31270008f 100644 --- a/include/config.h +++ b/include/config.h @@ -1775,7 +1775,15 @@ #undef CONFIG_USB_PD_CHECK_MAX_REQUEST_ALLOWED /* Default state of PD communication enabled flag */ -#define CONFIG_USB_PD_COMM_ENABLED 1 +#define CONFIG_USB_PD_COMM_ENABLED + +/* + * Do not enable PD communication in RO as a security measure. + * We don't want to allow communication to outside world until + * we jump to RW. This can by overridden with the removal of + * the write protect screw to allow for easier testing. + */ +#undef CONFIG_USB_PD_COMM_LOCKED /* Respond to custom vendor-defined messages over PD */ #undef CONFIG_USB_PD_CUSTOM_VDM |