diff options
author | Yilun Lin <yllin@google.com> | 2018-09-08 00:25:31 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:50 -0700 |
commit | 25091ec77eb8bec64011cd340fb01d3b63b88446 (patch) | |
tree | 06386ea5434085f169bd317292f713323981625f /include | |
parent | 8faef60c20ae6ffa4414fe9f4b47e6d0d8597348 (diff) | |
download | chrome-ec-25091ec77eb8bec64011cd340fb01d3b63b88446.tar.gz |
type: Rename mat33_t to mat33_float_t
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: Ia601bfc9f9fb311f6ca91bfa2e8fa34259ed6c5b
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215447
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/mat33.h | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/include/mat33.h b/include/mat33.h index 5dd77cbdb9..0b8b0123cb 100644 --- a/include/mat33.h +++ b/include/mat33.h @@ -10,21 +10,22 @@ #include "vec3.h" #include "util.h" -typedef float mat33_t[3][3]; +typedef float mat33_float_t[3][3]; typedef size_t sizev3_t[3]; -void init_zero_matrix(mat33_t A); -void init_diagonal_matrix(mat33_t A, float x); +void init_zero_matrix(mat33_float_t A); +void init_diagonal_matrix(mat33_float_t A, float x); -void mat33_scalar_mul(mat33_t A, float c); +void mat33_float_scalar_mul(mat33_float_t A, float c); -void mat33_swap_rows(mat33_t A, const size_t i, const size_t j); +void mat33_float_swap_rows(mat33_float_t A, const size_t i, const size_t j); -void mat33_get_eigenbasis(mat33_t S, floatv3_t eigenvals, mat33_t eigenvecs); +void mat33_float_get_eigenbasis(mat33_float_t S, floatv3_t eigenvals, + mat33_float_t eigenvecs); -size_t mat33_maxind(mat33_t A, size_t k); +size_t mat33_float_maxind(mat33_float_t A, size_t k); -void mat33_rotate(mat33_t A, float c, float s, +void mat33_float_rotate(mat33_float_t A, float c, float s, size_t k, size_t l, size_t i, size_t j); #endif /* __CROS_EC_MAT_33_H */ |