ec: Update U2F_ATTEST function for new-style key handles.

The existing implementation of this function was intended for
old-style key handles, and needs to be replaced with a new
implementation for new-style key handles that incorporate
user secrets.

For bonus points, the existing implementatation is actually
broken, and performs no verification, so will blindly attest
to anything, which is Not Good.

BUG=b:124237003
BRANCH=none
TEST=test_that firmware_Cr50U2fCommands

Change-Id: I9b4a487707acf81da39e6495adb42e277f2fdb4a
Signed-off-by: Louis Collard <louiscollard@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1475102
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Marius Schilder <mschilder@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

1 files changed, 1 insertions, 0 deletions

diff --git a/include/u2f.h b/include/u2f.h
index b2749c7eea..003f047175 100644
--- a/include/u2f.h
+++ b/include/u2f.h
@@ -121,6 +121,7 @@ typedef struct {
 } U2F_SIGN_RESP;
 
 typedef struct {
+    uint8_t userSecret[U2F_P256_SIZE];
     uint8_t format;
     uint8_t dataLen;
     uint8_t data[U2F_MAX_ATTEST_SIZE];