diff options
| author | Karthikeyan Ramasubramanian <kramasub@chromium.org> | 2019-06-12 11:30:49 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-20 00:49:26 +0000 |
| commit | 5936367096413abf294aa4584df53ec80bf8ef4c (patch) | |
| tree | 22b1ef0ea7e81953d5a4f32ebc3c9520d15e5572 /include | |
| parent | 1251719cc5fd3ca23ace14fe627b010e670b3cf9 (diff) | |
| download | chrome-ec-5936367096413abf294aa4584df53ec80bf8ef4c.tar.gz | |
ec_commands: Rename 'renew' to 'live' in EC_CMD_USB_PD_CHIP_INFO
Semantics of renew field in EC_CMD_USB_PD_CHIP_INFO is changing as
follows:
0 -> Return hard-coded info for Vendor ID/Product ID and cached info for
the Firmware Version
1 -> Return the live chip info for Vendor ID/Product ID/Firmware Version
Also rename the 'renew' field to 'live' to match the new semantics.
BUG=b:128820536,b:119046668
BRANCH=None
TEST=make -j buildall; Boot to ChromeOS.
Change-Id: Ie3dd022336b0be5c9728bb0ebabef32b7a6b5d57
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1617893
Tested-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Auto-Submit: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/ec_commands.h | 7 | ||||
| -rw-r--r-- | include/usb_pd_tcpm.h | 4 |
2 files changed, 8 insertions, 3 deletions
diff --git a/include/ec_commands.h b/include/ec_commands.h index fb1523b479..0861b3c34e 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -5171,7 +5171,12 @@ struct ec_response_usb_pd_mux_info { struct ec_params_pd_chip_info { uint8_t port; /* USB-C port number */ - uint8_t renew; /* Force renewal */ + /* + * Fetch the live chip info or hard-coded + cached chip info + * 0: hardcoded value for VID/PID, cached value for FW version + * 1: live chip value for VID/PID/FW Version + */ + uint8_t live; } __ec_align1; struct ec_response_pd_chip_info { diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index 9ca23e7ecb..858e7003d0 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -270,12 +270,12 @@ struct tcpm_drv { * Get firmware version. * * @param port Type-C port number - * @param renew Force renewal + * @param live Fetch live chip info or hard-coded + cached info * @param info Pointer to pointer to PD chip info * * @return EC_SUCCESS or error */ - int (*get_chip_info)(int port, int renew, + int (*get_chip_info)(int port, int live, struct ec_response_pd_chip_info_v1 **info); #ifdef CONFIG_USBC_PPC |