diff options
| author | Prashant Malani <pmalani@chromium.org> | 2019-09-16 00:56:30 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-09-23 02:57:29 +0000 |
| commit | e3890838a448db5ac7b4a11252d5aff5213f34ca (patch) | |
| tree | a35530cc1988107d177509c8e6f9781cba4d6844 /include | |
| parent | b3e56d049645a6cc148ff0670b525e29b3b553bc (diff) | |
| download | chrome-ec-e3890838a448db5ac7b4a11252d5aff5213f34ca.tar.gz | |
usb_pd: Send SOP' DiscIdent messages on SOP NAKs
Currently, the only scenario where an SOP' message is sent is when we
receive a SOP DiscIdentity Response from the UFP. However, we should be
able to query the cable characteristics even if the UFP responds with a
NAK. So, add handling to send a SOP' DiscIdentity even if we receive a
NAK. This will not otherwise disrupt the PD connection flow.
Note that there may be other situations where SOP' messages can be sent,
but aren't currently being sent.
BUG=chromium:1005941
BRANCH=None
TEST=make -j buildall; Test on a hatch with a Pixel 2 DUT. Cable
correctly responds with Cable information even after the EC
receives a UFP DiscIdentity NAK.
Change-Id: Ia856f2eb1547f09ae1dc0318021ad9f2458fc25a
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1808057
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/usb_pd.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/usb_pd.h b/include/usb_pd.h index 737490f6cc..0c58138d1b 100644 --- a/include/usb_pd.h +++ b/include/usb_pd.h @@ -708,6 +708,7 @@ struct active_cable_vdo2 { /* Cable structure for storing cable attributes */ struct pd_cable { + uint8_t is_identified; /* Type of cable */ enum idh_ptype type; /* Cable flags. See CABLE_FLAGS_* */ |