diff options
| author | Keith Short <keithshort@chromium.org> | 2020-02-19 17:56:12 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-29 01:19:14 +0000 |
| commit | 0eb3e2a0c7e71e461b2ee0375652bb61b28c1cb7 (patch) | |
| tree | d62b83b28f7e7f7cb66c6e353a51527bfba37ca0 /include | |
| parent | bb9998acdffc3176a119f5c8620345b832cf17f0 (diff) | |
| download | chrome-ec-0eb3e2a0c7e71e461b2ee0375652bb61b28c1cb7.tar.gz | |
volteer: Prevent glitch on SLP_S3_L during power on
Reconfigure the SLP_S3_L power interrupt as an output and drive this
signal low while the PP3300_A rail comes up. This prevents a glitch on
the SLP_S3_L signal that can affect the power sequencing.
BUG=b:143346794
BRANCH=none
TEST=make buildall
TEST=Verify Volteer boots. With debug code enabled, verify SLP_S3_L
drives low while PP3300 turns on.
Change-Id: Ic8204874cb9e68a1af27fafcf5274d50ce5cb38f
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068535
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/config.h | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/include/config.h b/include/config.h index 92c38fbc91..f54762844c 100644 --- a/include/config.h +++ b/include/config.h @@ -1114,6 +1114,13 @@ #undef CONFIG_CHIPSET_PP3300_RAIL_FIRST /* + * Enable the EC to drive SLP_S3_L during the G3 to S3 transition. This is + * needed on TigerLake designs to prevent a glitch on the SLP_S3_L and PCH_PWROK + * signals during power on. + */ +#undef CONFIG_CHIPSET_SLP_S3_L_OVERRIDE + +/* * Enable if chipset requires delay between power signals going high * and deasserting RSMRST to PCH. */ @@ -5111,6 +5118,11 @@ #define CONFIG_CHIPSET_X86_RSMRST_DELAY #endif +#if defined(CONFIG_HOSTCMD_ESPI_VW_SLP_S3) && \ + defined(CONFIG_CHIPSET_SLP_S3_L_OVERRIDE) +#error "Cannot use CONFIG_CHIPSET_SLP_S3_L_OVERRIDE if SLP_S3 is a virtual wire" +#endif + /*****************************************************************************/ /* |