diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2022-08-17 12:39:01 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-18 14:47:30 +0000 |
| commit | 3601351f5f9b75eb1d7f8cfaa4eedd11949ba31f (patch) | |
| tree | 240ed5a2ebd64fba046e8817212ad5835ecd51b5 /include | |
| parent | 623ac0bee5e61003be3a4744b298dcd509005a7a (diff) | |
| download | chrome-ec-3601351f5f9b75eb1d7f8cfaa4eedd11949ba31f.tar.gz | |
8042: Rename I8042_RET to ATKBD_RET
This change moves and renames some of the I8042_RET definitions into the
AT Keyboard protocol header. This way we can make sure we are not
intermixing 8042 return codes and AT keyboard return codes. I pulled
the AT turn codes from the spec.
BUG=b:242886255
BRANCH=none
TEST=build guybrush
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I677d052202419e9678d0a3c96aa35bf424ae7bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3835510
Reviewed-by: Yuval Peress <peress@google.com>
Code-Coverage: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/atkbd_protocol.h | 8 | ||||
| -rw-r--r-- | include/i8042_protocol.h | 4 |
2 files changed, 8 insertions, 4 deletions
diff --git a/include/atkbd_protocol.h b/include/atkbd_protocol.h index 70a4b4ca86..d8bab5aab6 100644 --- a/include/atkbd_protocol.h +++ b/include/atkbd_protocol.h @@ -34,4 +34,12 @@ #define ATKBD_CMD_RESEND 0xfe #define ATKBD_CMD_RESET 0xff +#define ATKBD_RET_OVERFLOW 0x00 +#define ATKBD_RET_TEST_SUCCESS 0xaa +#define ATKBD_RET_ECHO 0xee +#define ATKBD_RET_ACK 0xfa +#define ATKBD_RET_TEST_FAIL 0xfc +#define ATKBD_RET_INTERNAL_FAIL 0xfd +#define ATKBD_RET_RESEND 0xfe + #endif /* __CROS_EC_ATKBD_PROTOCOL_H */ diff --git a/include/i8042_protocol.h b/include/i8042_protocol.h index f5ca10dbf7..d4bcd86b42 100644 --- a/include/i8042_protocol.h +++ b/include/i8042_protocol.h @@ -48,13 +48,9 @@ /* port 0x60 return value */ #define I8042_RET_EMUL0 0xe0 #define I8042_RET_EMUL1 0xe1 -#define I8042_RET_ECHO 0xee #define I8042_RET_RELEASE 0xf0 #define I8042_RET_HANJA 0xf1 #define I8042_RET_HANGEUL 0xf2 -#define I8042_RET_ACK 0xfa -#define I8042_RET_TEST_FAIL 0xfc -#define I8042_RET_INTERNAL_FAIL 0xfd #define I8042_RET_NAK 0xfe #define I8042_RET_ERR 0xff |