diff options
| author | Alec Berg <alecaberg@chromium.org> | 2015-02-03 15:49:47 -0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-02-04 23:32:37 +0000 |
| commit | 19b6e5da2391bb7f75cf3aa29dddddfad75ff7c8 (patch) | |
| tree | ec2a47efcd619428ead37939e625d491fd50e0ee /include | |
| parent | 9590a539206ab783c0a453b8d74e3f02ee157e77 (diff) | |
| download | chrome-ec-19b6e5da2391bb7f75cf3aa29dddddfad75ff7c8.tar.gz | |
samus: fix lightbar tap sequence doesn't always show on AC event
Fix bug on samus that the battery status doesn't always show on
lightbar when AC is plugged/unplugged. It doesn't show when the
battery is full is S3 or S5 because in these states we turn off
CHARGE_EN so that ACOK to the EC never toggles.
Instead, what we want to do is display battery status whenever the
active charge port changes. This will happen when AC is plugged or
unplugged OR if a user has AC on both ports and toggles between
them using the charge override hot-keys.
BUG=chrome-os-partner:36317
BRANCH=samus
TEST=test plugging and unplugging AC on both sides when battery is
full and unit is in S0, and when unit is in S5. also tested lightbar
flashes battery percentage when two zingers are plugged in and you
switch between them using Ctrl+Search+0|1|2.
Change-Id: I5cd7fff4f466adf857f1e63f07f3b0c7ae8422c7
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/245922
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/host_command.h | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/include/host_command.h b/include/host_command.h index 4661e59dd6..4bf903e6ef 100644 --- a/include/host_command.h +++ b/include/host_command.h @@ -216,14 +216,11 @@ void host_throttle_cpu(int throttle); void host_command_pd_send_status(enum pd_charge_state new_chg_state); /** - * Ask the PD MCU for its status, obtaining the current charge_port as a - * side-effect (-1 means none or don't know). + * Get the active charge port from the PD * - * @param charge_port If present, updated with the current charge port: - * -1 == none/unknown, 0 == left, 1 == right. + * @return -1 == none/unknown, 0 == left, 1 == right. */ -void pd_exchange_status(int *charge_port); - +int pd_get_active_charge_port(void); /** * Send host command to PD MCU. |