diff options
author | Daisuke Nojiri <dnojiri@chromium.org> | 2020-05-22 14:01:18 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-06-09 00:53:33 +0000 |
commit | 7766098000110567b5e551a05b5d91ef85b29f3c (patch) | |
tree | 7cd764da82add7d9ae60b308f48bd57471c713ac /include | |
parent | 3e238583a45c036fed3aa62a8c82e47b6601e028 (diff) | |
download | chrome-ec-7766098000110567b5e551a05b5d91ef85b29f3c.tar.gz |
EFS2: Verify and jump when system shuts down in RO
Currently, when the system shuts down in RO, EC resets with AP_OFF
flag. This was for allowing the EC to jump to RW and get ready for
the next normal boot after a system shuts down from the recovery
mode (chromium:1045209).
This behavior causes the reboot from the recovery mode to be stopped
(b:154778457).
This patch makes RO jump to RW instead of resetting with AP_IDLE
flag. After sysjump, the AP can continue to sequence up or down.
BUG=b:154778457, chromium:1045209, b:156694627, b:157077589
BRANCH=none
TEST=test_that suite:faft_bios passes.
TEST=Press power button in recovery screen on Zork, Puff, Volteer.
System stays in S5 after sysjump.
TEST=firmware_CorruptBothFwSigAB passes on Zork, Puff, Volteer.
TEST=Hibernate EC on Zork, Puff, Volteer. Press power button once.
System boots.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: If08f3bb7f89c2407e4c5207ade820085f65ea9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2213359
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/config.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/config.h b/include/config.h index a593956d58..180fd863c7 100644 --- a/include/config.h +++ b/include/config.h @@ -4364,6 +4364,9 @@ * * EFS1 is being deprecated. EFS2 is faster, doesn't need two slots, and * supports rollback protection. + * + * EFS2 runs in the system task (a.k.a. main) and the hook task (for shutdown + * hook). Their stack sizes must be big enough for sha256. */ #undef CONFIG_VBOOT_EFS #undef CONFIG_VBOOT_EFS2 |