diff options
| author | David Huang <david.huang@quanta.corp-partner.google.com> | 2020-01-22 09:57:42 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-07 12:25:28 +0000 |
| commit | 4ffdafcff838b09bbbdea8c1bdfdaacd10d9be8a (patch) | |
| tree | 78177b8aae17d36c56890910c794bf118d0ca4f1 /power/cometlake.c | |
| parent | f42be6e2a1eefaee06ed7593373fbe6dedb3dd6c (diff) | |
| download | chrome-ec-4ffdafcff838b09bbbdea8c1bdfdaacd10d9be8a.tar.gz | |
Kindred: Fix reset trigger even system force to G3.
System will trigger reset when already force to G3.
Add board_chipset_forced_shutdown() in chipset_force_shutdown to
stop reset when system force to G3.
BUG=b:143440730
BRANCH=master
TEST=Power on system and make system enter G3 immediately.
Make sure system won't reset.
Change-Id: Ie601921af9adf08d2055cdecb0243e64bd57724f
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2014001
Tested-by: David Huang <david.huang@quanta.corp-partner.google.com>
Commit-Queue: David Huang <david.huang@quanta.corp-partner.google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'power/cometlake.c')
| -rw-r--r-- | power/cometlake.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/power/cometlake.c b/power/cometlake.c index af30e750f1..8328696751 100644 --- a/power/cometlake.c +++ b/power/cometlake.c @@ -55,6 +55,12 @@ BUILD_ASSERT(ARRAY_SIZE(power_signal_list) == POWER_SIGNAL_COUNT); static int forcing_shutdown; /* Forced shutdown in progress? */ +/* Default no action, overwrite it in board.c if necessary*/ +__overridable void board_chipset_forced_shutdown(void) +{ + return; +} + void chipset_force_shutdown(enum chipset_shutdown_reason reason) { int timeout_ms = 50; @@ -76,6 +82,11 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason) gpio_set_level(GPIO_EN_PP5000_A, 0); #endif + /* For b:143440730, stop checking GPIO_ALL_SYS_PGOOD if system is + * already force to G3. + */ + board_chipset_forced_shutdown(); + /* Need to wait a min of 10 msec before check for power good */ msleep(10); |