diff options
| author | Nicolas Boichat <drinkcat@chromium.org> | 2019-06-13 09:10:35 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-17 05:31:38 +0000 |
| commit | ddc1e52b75f5f6277af478630e5a0238394c31c4 (patch) | |
| tree | ff17aa57a28b3fae43c407b904ed9c5efe2c4f56 /power/mt8183.c | |
| parent | 7a1dfea02d3cb6ec16610ca284fbde2ab8145cea (diff) | |
| download | chrome-ec-ddc1e52b75f5f6277af478630e5a0238394c31c4.tar.gz | |
power/mt8183: Clarify comment about force PMIC shutdown
It turns out MT6358 cannot be configured to shut down when receiving
WATCHDOG input, so the statement in the comment is incorrect.
However, it is still correct to say that forcing PMIC shutdown should
be rare. And add a note that PMIC RTC state will be lost.
BRANCH=none
BUG=b:109850749, b:134912821
TEST=none
Change-Id: I7c84b012d7095fb94473303c83b4ffecb01ee5da
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1657074
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>
Diffstat (limited to 'power/mt8183.c')
| -rw-r--r-- | power/mt8183.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/power/mt8183.c b/power/mt8183.c index b4795a3e34..244cb5f8de 100644 --- a/power/mt8183.c +++ b/power/mt8183.c @@ -386,8 +386,9 @@ enum power_state power_handle_state(enum power_state state) case POWER_S5G3: /* * If PMIC is still not off, assert PMIC_FORCE_RESET_ODL. - * This should not happen if PMIC is configured properly, and - * shuts down upon receiving WATCHDOG. + * This should only happen for forced shutdown where the AP is + * not able to send a command to the PMIC. Also, PMIC will lose + * RTC state, in that case. */ if (power_get_signals() & IN_PGOOD_PMIC) { CPRINTS("Forcing PMIC off"); |