diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2018-02-07 19:37:52 -0800 |
|---|---|---|
| committer | Daisuke Nojiri <dnojiri@chromium.org> | 2018-02-08 13:57:12 -0800 |
| commit | 425a4171b0f9a9dd24bae6b884c34642eb299a7a (patch) | |
| tree | fce7b93fde2b1396fa2390d3b79036b0a7dc72d7 /power | |
| parent | 90030535837052dc64f863de427ea8a0faaf9430 (diff) | |
| download | chrome-ec-425a4171b0f9a9dd24bae6b884c34642eb299a7a.tar.gz | |
Fizz: Execute PMIC reset before vboot_main
When AP requests cold reboot, currently EC does not perform PMIC
reset because chipset_handle_reboot is executed only after EC jumps
to RW. This causes EC to miss CHIPSET_STARTUP and CHIPSET_RESUME
events because power rails do not cycle.
This patch will make EC execute PMIC reset to before vboot_main.
BUG=b:73093795
BRANCH=none
TEST=reboot, reboot ap-off, verify USB ports are powered after
transitionining to dev mode.
Change-Id: Ic04395d8a4bff45d9fc60601b07c600dfb75d9c0
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/908094
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'power')
| -rw-r--r-- | power/skylake.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/power/skylake.c b/power/skylake.c index 9cad5baaf4..61c07fb70e 100644 --- a/power/skylake.c +++ b/power/skylake.c @@ -124,7 +124,7 @@ __attribute__((weak)) int board_has_working_reset_flags(void) } #ifdef CONFIG_CHIPSET_HAS_PLATFORM_PMIC_RESET -static void chipset_handle_reboot(void) +void chipset_handle_reboot(void) { int flags; @@ -167,5 +167,7 @@ static void chipset_handle_reboot(void) while (1) ; /* wait here */ } +#ifndef CONFIG_VBOOT_EFS DECLARE_HOOK(HOOK_INIT, chipset_handle_reboot, HOOK_PRIO_FIRST); #endif +#endif /* CONFIG_CHIPSET_HAS_PLATFORM_RESET */ |