power: Add default cases for power state handlers

In preparation for the addition of the new POWER_S4 state (and
transition states) coming in, add default cases for ARM power state
handlers, which won't be adding phony transitions through a non-existent
S4 state.

BRANCH=None
BUG=b:204947672
TEST=hiberman hibernate --test-keys on volteer

Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I48c884131037cbff917230134a34718c32ce75db
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3286183
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

8 files changed, 42 insertions, 0 deletions

diff --git a/power/falconlite.c b/power/falconlite.c
index d2f8e5952a..b418edfd84 100644
--- a/power/falconlite.c
+++ b/power/falconlite.c
@@ -462,6 +462,11 @@ enum power_state power_handle_state(enum power_state state)
 	case POWER_S5G3:
 		power_seq_run(s5g3_power_seq, ARRAY_SIZE(s5g3_power_seq));
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/mt817x.c b/power/mt817x.c
index 8f11af2364..30d3ffed1e 100644
--- a/power/mt817x.c
+++ b/power/mt817x.c
@@ -748,6 +748,12 @@ enum power_state power_handle_state(enum power_state state)
 
 	case POWER_S5G3:
 		return POWER_G3;
+
+	default:
+		/* Elm does not have space for such an extravagant print. */
+		/* CPRINTS("Unexpected power state %d", state); */
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/mt8183.c b/power/mt8183.c
index ddf49799e9..7c747541a6 100644
--- a/power/mt8183.c
+++ b/power/mt8183.c
@@ -570,6 +570,11 @@ enum power_state power_handle_state(enum power_state state)
 		}
 
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/mt8192.c b/power/mt8192.c
index 19cf6411ac..3cb6e164d8 100644
--- a/power/mt8192.c
+++ b/power/mt8192.c
@@ -32,6 +32,7 @@
 #include "system.h"
 #include "task.h"
 #include "timer.h"
+#include "util.h"
 
 #ifdef CONFIG_BRINGUP
 #define GPIO_SET_LEVEL(signal, value) \
@@ -475,6 +476,11 @@ enum power_state power_handle_state(enum power_state state)
 			return POWER_S5;
 
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/qcom.c b/power/qcom.c
index a119ce23d6..2310dfedfa 100644
--- a/power/qcom.c
+++ b/power/qcom.c
@@ -1119,6 +1119,11 @@ enum power_state power_handle_state(enum power_state state)
 
 	case POWER_S5G3:
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/rk3288.c b/power/rk3288.c
index 39f19ddeff..851a8b4e9d 100644
--- a/power/rk3288.c
+++ b/power/rk3288.c
@@ -506,6 +506,11 @@ enum power_state power_handle_state(enum power_state state)
 
 	case POWER_S5G3:
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/rk3399.c b/power/rk3399.c
index c1693057b9..e0ea7ee483 100644
--- a/power/rk3399.c
+++ b/power/rk3399.c
@@ -529,6 +529,11 @@ enum power_state power_handle_state(enum power_state state)
 
 	case POWER_S5G3:
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;
diff --git a/power/sdm845.c b/power/sdm845.c
index 7157f98cc3..7463e00069 100644
--- a/power/sdm845.c
+++ b/power/sdm845.c
@@ -823,6 +823,11 @@ enum power_state power_handle_state(enum power_state state)
 
 	case POWER_S5G3:
 		return POWER_G3;
+
+	default:
+		CPRINTS("Unexpected power state %d", state);
+		ASSERT(0);
+		break;
 	}
 
 	return state;