diff options
| author | Rachel Nancollas <rachelsn@google.com> | 2019-03-13 11:26:58 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-14 20:53:42 -0700 |
| commit | de8faeaf3ec3f9f5aae6ced1eaae726abead8819 (patch) | |
| tree | a2b8b058db41dd22789487c691e6174b5e716ed7 /power | |
| parent | 7f0df1604c7a439c1c3bcbfe755468c08420a7ac (diff) | |
| download | chrome-ec-de8faeaf3ec3f9f5aae6ced1eaae726abead8819.tar.gz | |
cometlake: pass RSMRST_L to PCH early to meet tPCH12
tPCH12 dictates that _A rails should go low >= 400ns
of RSMRST_L going low. Waiting for this to propagate through
the power good chip and EC takes too long. This patch asserts
RSMRST_L to the PCH as soon as we the chipset shuts down to
meet this timing.
BRANCH=none
BUG=b:124924912
TEST=Veify on scope that PP3300_A goes low >= 400ns of
EC_PCH_RSMRST_L going low during a regular shutdown.
Change-Id: I7e6691159f58bc70a0078af53652f8efca3094ff
Signed-off-by: Rachel Nancollas <rachelsn@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1520768
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'power')
| -rw-r--r-- | power/cometlake.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/power/cometlake.c b/power/cometlake.c index bf27b50dab..466aa4d6c5 100644 --- a/power/cometlake.c +++ b/power/cometlake.c @@ -27,6 +27,9 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason) CPRINTS("%s(%d)", __func__, reason); report_ap_reset(reason); + /* Turn off RSMRST_L to meet tPCH12 */ + gpio_set_level(GPIO_EC_PCH_RSMRST_L, 0); + /* Turn off A (except PP5000_A) rails*/ gpio_set_level(GPIO_EN_A_RAILS, 0); |