diff options
| author | Diana Z <dzigterman@chromium.org> | 2022-07-01 17:15:04 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-07-06 22:25:41 +0000 |
| commit | 8523520d17176c6903daa1c769637e154bc6ba67 (patch) | |
| tree | 7cf2b18b3b7c0899a954d46c2fd8626021f91ff1 /power | |
| parent | 738de2b575de93f71f3a95f9294b9006f4f7b008 (diff) | |
| download | chrome-ec-8523520d17176c6903daa1c769637e154bc6ba67.tar.gz | |
AMD: Remove S0ix interrupt enable/disable
Initially, the S0ix interrupts were being enabled and disabled since
they were copied from the Intel power sequencing code. However, this
isn't necessary on AMD and causes problems on platforms which share
the S3 and S0ix signaling.
BRANCH=None
BUG=b:237581881
TEST=on skyrim, ensure repeated boots and suspend work. On nipperkin,
ensure suspend stress test runs well
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I7119091064cfafe0ab7cfba756c95e9561ec362a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3741226
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'power')
| -rw-r--r-- | power/amd_x86.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/power/amd_x86.c b/power/amd_x86.c index af426a567b..9b4300671d 100644 --- a/power/amd_x86.c +++ b/power/amd_x86.c @@ -300,7 +300,6 @@ power_chipset_handle_host_sleep_event(enum host_sleep_event state, sleep_set_notify(SLEEP_NOTIFY_SUSPEND); sleep_start_suspend(ctx); - power_signal_enable_interrupt(GPIO_PCH_SLP_S0_L); } else if (state == HOST_SLEEP_EVENT_S0IX_RESUME) { /* * Wake up chipset task and indicate to power state machine that @@ -309,7 +308,6 @@ power_chipset_handle_host_sleep_event(enum host_sleep_event state, sleep_set_notify(SLEEP_NOTIFY_RESUME); task_wake(TASK_ID_CHIPSET); lpc_s0ix_resume_restore_masks(); - power_signal_disable_interrupt(GPIO_PCH_SLP_S0_L); sleep_complete_resume(ctx); /* * If the sleep signal timed out and never transitioned, then @@ -318,8 +316,6 @@ power_chipset_handle_host_sleep_event(enum host_sleep_event state, * mask to its S0 state now. */ power_update_wake_mask(); - } else if (state == HOST_SLEEP_EVENT_DEFAULT_RESET) { - power_signal_disable_interrupt(GPIO_PCH_SLP_S0_L); } #endif /* CONFIG_POWER_S0IX */ } |