diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-08-13 09:44:34 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-08-13 22:32:17 +0000 |
| commit | 0df97d0e5846493c868eabe4c1647d67a946d7fd (patch) | |
| tree | 100e343403bb91aabf8661fbf85e1dcf07b16676 /test/usb_typec_ctvpd.c | |
| parent | 39a526023e435a776639d68271eed593598e9106 (diff) | |
| download | chrome-ec-0df97d0e5846493c868eabe4c1647d67a946d7fd.tar.gz | |
test: remove no_empty_state tests
When we use IS_ENABLED style code we may have empty state machine states
that are unused. The linker ensures that we never try to reference these
states. This does mean that extra states do cost ~20 bytes each. This
cost does seem worth it to keep the value of usb states stable.
BRANCH=none
BUG=none
TEST=buildall
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I44c1454bed91c9e28d89ebd6b75e9df684c41844
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2354192
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'test/usb_typec_ctvpd.c')
| -rw-r--r-- | test/usb_typec_ctvpd.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/usb_typec_ctvpd.c b/test/usb_typec_ctvpd.c index 08c23eb284..1340c7a093 100644 --- a/test/usb_typec_ctvpd.c +++ b/test/usb_typec_ctvpd.c @@ -1523,7 +1523,6 @@ void run_test(int argc, char **argv) /* Do basic state machine validity checks last. */ RUN_TEST(test_tc_no_parent_cycles); - RUN_TEST(test_tc_no_empty_state); RUN_TEST(test_tc_all_states_named); /* @@ -1532,7 +1531,6 @@ void run_test(int argc, char **argv) * te PE statemachine here so we don't have to create another test exe */ RUN_TEST(test_pe_no_parent_cycles); - RUN_TEST(test_pe_no_empty_state); RUN_TEST(test_pe_all_states_named); test_print_result(); |