diff options
| author | Namyoon Woo <namyoon@chromium.org> | 2019-06-07 15:21:07 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-14 05:22:04 +0000 |
| commit | 2d62dee3a8f32499bab8f4b95b84a9eaeea919dc (patch) | |
| tree | 5ddc05c08c1e273d8190c1eafc4740d5384ee97c /test | |
| parent | 2a528cc40b9aaa80798d1146f1a3f4a7548a329d (diff) | |
| download | chrome-ec-2d62dee3a8f32499bab8f4b95b84a9eaeea919dc.tar.gz | |
g: minor fix in putting a character into usb_console tx queue
When __tx_char attempts to push a character into tx_queue,
it doesn't return an error if it fails. Eventually usb_puts()
doesn't recognize tx queue getting full if it happens, and processes
all characters, and always return EC_SUCCESS.
BUG=None
BRANCH=None
TEST=ran uart_usb_tester on bob.
uart_stress_tester.sh --pty="/dev/ttyUSB0 /dev/ttyUSB2 /dev/ttyUSB1"
--min_char 400000
INFO : ChromeOS UART stress test starts.
INFO : UART devices: /dev/ttyUSB0 /dev/ttyUSB2 /dev/ttyUSB1
......................................................
INFO : /dev/ttyUSB0: 0 lost / 483415 : 0 %
ERROR : /dev/ttyUSB2: 277497 lost / 415835 : 66.7 %
ERROR : /dev/ttyUSB1: 244459 lost / 400575 : 61.0 %
INFO : Test files are in /tmp/uart_stress_tester.sh_latest
INFO : and also in /tmp/tmp.X7jwZfxNe2.uart_stress_tester.sh.
ERROR : FAIL
CR50 console (/dev/ttyUSB0) error rate got improved from 4~7% to
0 %.
Change-Id: I5ae0b7bd494fbc29978ce3e87531e246a9be51f8
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1650622
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions