summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorJett Rink <jettrink@chromium.org>2019-10-17 07:52:12 -0600
committerCommit Bot <commit-bot@chromium.org>2019-10-24 00:44:34 +0000
commit5f683e3de7f605302ec8af791044cff23b0920ee (patch)
tree13a8448ab03f8ccf31bff8519ecd2dc377854391 /test
parentcb2fa8b437cb14e652f0e6374d3caf8e568a04ac (diff)
downloadchrome-ec-5f683e3de7f605302ec8af791044cff23b0920ee.tar.gz
cleanup: use power and data role enums instead of int
Use first class enums types instead of int for power and data role. BRANCH=none BUG=none TEST=builds and new stack works with single charger on C1 hatch Change-Id: Ied4562e6a148803140cf277bd229b6c3ed801470 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1865985 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'test')
-rw-r--r--test/fake_usbc.c13
-rw-r--r--test/usb_prl.c8
2 files changed, 11 insertions, 10 deletions
diff --git a/test/fake_usbc.c b/test/fake_usbc.c
index f9cb69f4c9..9f2d4c12ae 100644
--- a/test/fake_usbc.c
+++ b/test/fake_usbc.c
@@ -6,6 +6,7 @@
*/
#include "common.h"
#include "usb_tc_sm.h"
+#include "usb_pd.h"
int pd_is_vbus_present(int port)
{
@@ -25,22 +26,22 @@ void pd_request_vconn_swap_on(int port)
{}
-static int data_role;
-int tc_get_data_role(int port)
+static enum pd_data_role data_role;
+enum pd_data_role tc_get_data_role(int port)
{
return data_role;
}
-void tc_set_data_role(int port, int role)
+void tc_set_data_role(int port, enum pd_data_role role)
{
data_role = role;
}
-static int power_role;
-int tc_get_power_role(int port)
+static enum pd_power_role power_role;
+enum pd_power_role tc_get_power_role(int port)
{
return power_role;
}
-void tc_set_power_role(int port, int role)
+void tc_set_power_role(int port, enum pd_power_role role)
{
power_role = role;
}
diff --git a/test/usb_prl.c b/test/usb_prl.c
index 308117493b..58bd452e60 100644
--- a/test/usb_prl.c
+++ b/test/usb_prl.c
@@ -95,8 +95,8 @@ static uint32_t test_data[] = {
static struct pd_prl {
int rev;
int pd_enable;
- int power_role;
- int data_role;
+ enum pd_power_role power_role;
+ enum pd_data_role data_role;
int msg_tx_id;
int msg_rx_id;
@@ -723,12 +723,12 @@ static void enable_prl(int port, int en)
prl_set_rev(port, pd_port[port].rev);
}
-int tc_get_power_role(int port)
+enum pd_power_role tc_get_power_role(int port)
{
return pd_port[port].power_role;
}
-int tc_get_data_role(int port)
+enum pd_data_role tc_get_data_role(int port)
{
return pd_port[port].data_role;
}