diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-08-07 09:50:11 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-08-13 22:32:15 +0000 |
| commit | 39a526023e435a776639d68271eed593598e9106 (patch) | |
| tree | 743fa4d30fa2ad4dfbdbcc8b8f52f0ae8ffa84fe /test | |
| parent | 0212d4a3ce01452ddaba46f076f90e9a5e90e589 (diff) | |
| download | chrome-ec-39a526023e435a776639d68271eed593598e9106.tar.gz | |
tcpmv2: wait before enabling HW auto toggle
We need to ensure that the previous Rd or Rp has been held long enough
before we transition into hardware auto toggle otherwise the first
toggle might be too short and violate the DRP timing spec
BRANCH=none
BUG=b:163095971
TEST=Verify on scope
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I92e9f5ca7dbca2b347e438d774551cc11476195b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2343176
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'test')
| -rw-r--r-- | test/test_config.h | 1 | ||||
| -rw-r--r-- | test/usb_typec_drp_acc_trysrc.c | 26 |
2 files changed, 27 insertions, 0 deletions
diff --git a/test/test_config.h b/test/test_config.h index e52d9b8995..0c74657d2a 100644 --- a/test/test_config.h +++ b/test/test_config.h @@ -414,6 +414,7 @@ int ncp15wb_calculate_temp(uint16_t adc); #define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_PD_PORT_MAX_COUNT 1 #define CONFIG_USBC_SS_MUX +#define CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE #define CONFIG_USB_PD_VBUS_DETECT_TCPC #define CONFIG_USB_POWER_DELIVERY #undef CONFIG_USB_PRL_SM diff --git a/test/usb_typec_drp_acc_trysrc.c b/test/usb_typec_drp_acc_trysrc.c index 1578a04390..ce1b02e5bc 100644 --- a/test/usb_typec_drp_acc_trysrc.c +++ b/test/usb_typec_drp_acc_trysrc.c @@ -660,6 +660,31 @@ __maybe_unused static int test_cc_rd_on_por_reset(void) return EC_SUCCESS; } +__maybe_unused static int test_auto_toggle_delay(void) +{ + uint64_t time; + + /* Start with auto toggle disabled so we can time the transition */ + pd_set_dual_role(PORT0, PD_DRP_TOGGLE_OFF); + task_wait_event(SECOND); + + /* Enabled auto toggle and start the timer for the transition */ + pd_set_dual_role(PORT0, PD_DRP_TOGGLE_ON); + time = get_time().val; + + /* + * Ensure we do not transition to auto toggle from Rd or Rp in less time + * than tDRP minimum (50 ms) * dcSRC.DRP minimum (30%) = 15 ms. + * Otherwise we can confuse external partners with the first transition + * to auto toggle. + */ + task_wait_event(SECOND); + TEST_GT(mock_tcpc.first_call_to_enable_auto_toggle - time, + 15ul * MSEC, "%lu"); + + return EC_SUCCESS; +} + /* TODO(b/153071799): test as SNK monitor for Vbus disconnect (not CC line) */ /* TODO(b/153071799): test as SRC monitor for CC line state change */ @@ -708,6 +733,7 @@ void run_test(int argc, char **argv) RUN_TEST(test_cc_open_on_normal_reset); RUN_TEST(test_cc_rd_on_por_reset); + RUN_TEST(test_auto_toggle_delay); /* Do basic state machine validity checks last. */ RUN_TEST(test_tc_no_parent_cycles); |