diff options
| author | Jeremy Bettis <jbettis@chromium.org> | 2022-09-26 21:37:59 +0000 |
|---|---|---|
| committer | Jeremy Bettis <jbettis@chromium.org> | 2022-09-26 21:58:52 +0000 |
| commit | 55ef7a03129eb301a51c5539672d910d1243187f (patch) | |
| tree | 7894ef17c768cb7d43b11ef0bfc6b399bc5caec3 /third_party | |
| parent | 0e9c5579f042c6f6e68d8ccaafa5dd615d6f5580 (diff) | |
| download | chrome-ec-55ef7a03129eb301a51c5539672d910d1243187f.tar.gz | |
Revert "common: replace safe_memcmp with cryptoc version"
This reverts commit 85554f0a843daa1c85ba252c7a27a389968d347b.
Reason for revert: Broke gitlab (https://gitlab.com/zephyr-ec/ec/-/pipelines/651162463) and also CQ emerge builds (https://ci.chromium.org/ui/p/chromeos/builders/postsubmit/nissa-postsubmit/16030/overview)
Original change's description:
> common: replace safe_memcmp with cryptoc version
>
> We now have to always link against cryptoc, but it does not increase
> code size on our most constrained boards:
>
> Before and after both show:
>
> Smallest free spaces in RO flash (bytes):
> pdeval-stm32f072: 88
> servo_v4 : 104
> fusb307bgevb: 156
>
> Smallest free spaces in RW flash (bytes):
> volteer : 516
> bobba : 712
> meep : 716
>
> Tightest boards' RW RAM images, bytes free:
> whiskers : 212
> minimuffin: 284
> zinger : 284
>
> BRANCH=none
> BUG=b:169156874
> TEST=make buildall
>
> Signed-off-by: Tom Hughes <tomhughes@chromium.org>
> Change-Id: I98422eccb3e903bd82ddb386087dd2d55d1f845e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424068
> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Bug: b:169156874
Change-Id: I794ae31f9e217677471b0ff164fadc9623571a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3919500
Commit-Queue: Raul Rangel <rrangel@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Diffstat (limited to 'third_party')
| -rw-r--r-- | third_party/rules.mk | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/third_party/rules.mk b/third_party/rules.mk index 38ebcf8d3f..eb4391b70c 100644 --- a/third_party/rules.mk +++ b/third_party/rules.mk @@ -9,6 +9,7 @@ # Build and link against libcryptoc. # See https://chromium.googlesource.com/chromiumos/third_party/cryptoc . +ifeq ($(CONFIG_LIBCRYPTOC),y) # The cryptoc path can be overridden on invocation, as in the following example: # $ make CRYPTOC_DIR=~/src/cryptoc BOARD=bloonchipper @@ -52,3 +53,5 @@ test-targets=$(foreach test,$(test-list-y),\ $(out)/RW/$(test).RW.elf $(out)/RO/$(test).RO.elf) $(test-targets): LDFLAGS_EXTRA += $(CRYPTOC_LDFLAGS) $(test-targets): $(out)/cryptoc/libcryptoc.a + +endif # CONFIG_LIBCRYPTOC |