diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2012-10-10 17:43:02 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-10-11 14:24:43 -0700 |
| commit | d6f05e0d616e4004b0bb0404b6c8dbe9f9198db4 (patch) | |
| tree | d1f0077dd2c7989ccad4b892660dc9ead7c79fb3 /util/lbplay.c | |
| parent | b00a446ec57323f84002722523783351f19e41b1 (diff) | |
| download | chrome-ec-d6f05e0d616e4004b0bb0404b6c8dbe9f9198db4.tar.gz | |
Parameterize the lightbar behavior as much as possible.
This change replaces most of the hard-coded lightbar constants with values
that can be updated at run-time, so that if we change our minds about colors
and timing we can tweak some of the values without requiring an EC/BIOS
update.
It also adds the "ectool lightbar params" command to get and set those
values from the host. You can see the values from the EC console ("lightbar
params"), but there's no way to set them.
BUG=chrome-os-partner:8039
BRANCH=Link
TEST=manual
From the EC console, run
lightbar params
It should display the current values that can be changed.
Log in to the host and run this to see the same values:
ectool lightbar params
Or edit and change them with this:
ectool lightbar params > /tmp/vals.txt
vi /tmp/vals.txt
ectool lightbar params /tmp/vals.txt
The updated parameters are persistent across EC jumps (RO->RW), but are lost
when/if the EC reboots (as it will after the AP is off for 24 hours, for
example).
Change-Id: Ic2a3fd6f8062673432b48904933e0c7239b8658b
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/35289
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'util/lbplay.c')
| -rw-r--r-- | util/lbplay.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/lbplay.c b/util/lbplay.c index 8658368160..907374e9cc 100644 --- a/util/lbplay.c +++ b/util/lbplay.c @@ -35,7 +35,9 @@ static const struct { LB_SIZES(reg), LB_SIZES(rgb), LB_SIZES(get_seq), - LB_SIZES(demo) + LB_SIZES(demo), + LB_SIZES(get_params), + LB_SIZES(set_params) }; #undef LB_SIZES |