diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-06-28 15:50:43 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-06-29 10:46:18 -0700 |
| commit | 7e50e844a3bf1888f5abfa57cc82a6f94b87cbe2 (patch) | |
| tree | cae0ab6e5aa33bf14630ce93b2b02c62e2ff64c0 /util/lbplay.c | |
| parent | 70718f97e3afd8621a15a5d281a82a057d35b21a (diff) | |
| download | chrome-ec-7e50e844a3bf1888f5abfa57cc82a6f94b87cbe2.tar.gz | |
Change ec_command() to return negative values for errors
This is more compatible with kernel and u-boot, and will make it
easier to share code between the ec project and those.
BUG=none
TEST=manual:
ectool version -> should work normally
on ec, do 'hostevent set 0x40000'. Then at root shell
ectool queryec
EC returned error result code 19
ectool flashread 0x100000 16 foo
Reading 16 bytes at offset 1048576...
EC returned error result code 2
Read error at offset 0
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Change-Id: I5e2a85f96c874d0730c14e1438a533649cd594f8
Reviewed-on: https://gerrit.chromium.org/gerrit/26359
Commit-Ready: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'util/lbplay.c')
| -rw-r--r-- | util/lbplay.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/lbplay.c b/util/lbplay.c index 71511c581c..8b0c014cfe 100644 --- a/util/lbplay.c +++ b/util/lbplay.c @@ -131,7 +131,7 @@ void wait_for_ec_to_stop(void) fprintf(stderr, "EC isn't responding\n"); exit(1); } - } while (r != 0 && param.out.get_seq.num != LIGHTBAR_STOP); + } while (r < 0 && param.out.get_seq.num != LIGHTBAR_STOP); } int main(int argc, char **argv) |