diff options
| author | Fabio Baltieri <fabiobaltieri@google.com> | 2023-05-10 10:47:51 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-10 20:39:51 +0000 |
| commit | f897c90be36c04e796a7b5f2ac07281b19ee32e8 (patch) | |
| tree | a2ab16c1fa9f2e6348bb39511484c3dfbe81ed34 /util | |
| parent | b320aa5d74da54ab14c1ff54d41200aa259b7ec6 (diff) | |
| download | chrome-ec-f897c90be36c04e796a7b5f2ac07281b19ee32e8.tar.gz | |
util: preupload: make filename argument optional
The filename argument is meant to take ${PRESUBMIT_FILES} from the
presubmit config, but the file list can be empty if the commit only
contains deleted files.
Change the argument nargs value from "+" to "*" to allow running the
scripts with no arguments, they become a noop in this case instead of
failing with:
check_cprints.py: error: the following arguments are required: filename
BUG=none
TEST=repo upload on a patch with only deleted files
Change-Id: Id77c745651fd30d4a005f2b0decada9a72c50592
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4518770
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/preupload/lib.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/preupload/lib.py b/util/preupload/lib.py index 87a1226507..ced5f2a980 100644 --- a/util/preupload/lib.py +++ b/util/preupload/lib.py @@ -30,5 +30,5 @@ def argument_parser(): """Returns an ArgumentParser with standard options configured.""" parser = argparse.ArgumentParser() parser.add_argument("-c", "--commit", default=PRE_SUBMIT) - parser.add_argument("filename", nargs="+", type=Path) + parser.add_argument("filename", nargs="*", type=Path) return parser |