diff options
| author | Todd Broch <tbroch@chromium.org> | 2014-11-17 15:50:02 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-12-01 20:31:00 +0000 |
| commit | 63277d145b933325fcac9a1daecc39de0a86e4bc (patch) | |
| tree | b22f4682f022069844e02d4f1f9f7fb9f742ea0a /util | |
| parent | f6e45879d7302284312140b9abb06e16086b00a6 (diff) | |
| download | chrome-ec-63277d145b933325fcac9a1daecc39de0a86e4bc.tar.gz | |
pd: ectool: Allow different payload sizes for flashpd.
Dingdong & Hoho have different sized internal flash so the RW payload
can't be fixed. CL removes check as operators should know be capable
of picking correct payload.
Signed-off-by: Todd Broch <tbroch@chromium.org>
BRANCH=samus
BUG=chrome-os-partner:31192,chrome-os-partner:31193
TEST=manual,
<copy build/zinger/ec.RW.bin to samus>
# reserved dev_id w/ zinger RW payload.
ectool --name cros_pd flashpd 0 1 /tmp/ec.RW.bin
Reading 65536 bytes from /tmp/ec.RW.bin...
payload size 65536 but expected 0
# hoho dev_id w/ zinger RW payload.
ectool --name cros_pd flashpd 4 1 /tmp/ec.RW.bin
Reading 16384 bytes from /tmp/ec.RW.bin...
payload size 16384 but expected 65536
# bogus dev_id
ectool --name cros_pd flashpd 99 1 /tmp/ec.RW.bin
Unknown device ID 99
# zinger dev_id w/ zinger RW payload
ectool --name cros_pd flashpd 1 1 /tmp/ec.RW.bin
Reading 16384 bytes from /tmp/ec.RW.bin...
Erasing expected RW hash
Rebooting
Erasing RW flash
Writing RW flash
Change-Id: I49ad81edb04f359154fbff6710484c0d095069f7
Reviewed-on: https://chromium-review.googlesource.com/231831
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/ectool.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/util/ectool.c b/util/ectool.c index d6c47a7407..da16c8e3c4 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -886,9 +886,6 @@ int cmd_pd_device_info(int argc, char *argv[]) return rv; } - -/* PD image size is 16k minus 32 bits for the RW hash */ -#define PD_RW_IMAGE_SIZE (16 * 1024) int cmd_flash_pd(int argc, char *argv[]) { struct ec_params_usb_pd_fw_update *p = @@ -922,10 +919,6 @@ int cmd_flash_pd(int argc, char *argv[]) if (!buf) return -1; - /* Verify size of file */ - if (fsize != PD_RW_IMAGE_SIZE) - goto pd_flash_error; - /* Erase the current RW RSA signature */ fprintf(stderr, "Erasing expected RW hash\n"); p->cmd = USB_PD_FW_ERASE_SIG; |