diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-06-03 13:02:27 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-06-10 16:15:53 -0700 |
| commit | 0c4210b1d36d0c172cb621e10169a7d57c4358b0 (patch) | |
| tree | f7030e434b4c5e142d2697754ddffdd9876943a3 /util | |
| parent | f824e2abc5763fb9aaa5d0e17a9d2f29223138b5 (diff) | |
| download | chrome-ec-0c4210b1d36d0c172cb621e10169a7d57c4358b0.tar.gz | |
ectool: Clarify addressing mode for I2C commands
This patch updates the help message for i2cread, i2cwrite, i2cxfer
to clarify which addressing mode (7-bit or 8-bit) each command uses.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=chromium:971296
BRANCH=none
TEST=buildall
Change-Id: I757e8a1d30ad19dbc333a30a97f8049f007853d1
Reviewed-on: https://chromium-review.googlesource.com/1641600
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/ectool.c | 27 |
1 files changed, 19 insertions, 8 deletions
diff --git a/util/ectool.c b/util/ectool.c index 76f3c2cc18..32fe0092c3 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -6067,6 +6067,22 @@ int do_i2c_xfer(unsigned int port, unsigned int addr, return 0; } +static void cmd_i2c_help(void) +{ + fprintf(stderr, + " Usage: i2cread <8 | 16> <port> <addr8> <offset>\n" + " Usage: i2cwrite <8 | 16> <port> <addr8> <offset> <data>\n" + " Usage: i2cxfer <port> <addr7> <read_count> [bytes...]\n" + " <port> i2c port number\n" + " <addr8> 8-bit i2c address\n" + " <addr7> 7-bit i2c address\n" + " <offset> offset to read from or write to\n" + " <data> data to write\n" + " <read_count> number of bytes to read\n" + " [bytes ...] data to write\n" + ); + +} int cmd_i2c_read(int argc, char *argv[]) { @@ -6078,8 +6094,7 @@ int cmd_i2c_read(int argc, char *argv[]) int rv; if (argc != 5) { - fprintf(stderr, "Usage: %s <8 | 16> <port> <addr> <offset>\n", - argv[0]); + cmd_i2c_help(); return -1; } @@ -6131,9 +6146,7 @@ int cmd_i2c_write(int argc, char *argv[]) int rv; if (argc != 6) { - fprintf(stderr, - "Usage: %s <8 | 16> <port> <addr> <offset> <data>\n", - argv[0]); + cmd_i2c_help(); return -1; } @@ -6191,9 +6204,7 @@ int cmd_i2c_xfer(int argc, char *argv[]) int rv, i; if (argc < 4) { - fprintf(stderr, - "Usage: %s <port> <slave_addr> <read_count> " - "[write bytes...]\n", argv[0]); + cmd_i2c_help(); return -1; } |