diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2021-03-11 13:17:35 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-16 17:07:09 +0000 |
| commit | 6cfeb59fb53fcdc9787684de0497aca663810c9a (patch) | |
| tree | 53c069ff6b27858b4d756ca9803975782032aeb0 /util | |
| parent | 4ebe0f98623c3df5e1ab0d1265a9a77419946957 (diff) | |
| download | chrome-ec-6cfeb59fb53fcdc9787684de0497aca663810c9a.tar.gz | |
PCHG: Fix potential error=maybe-uninitialized in cmd_pchg_update_write
block_size is necessarily initialized if cmd_pchg_update_open returns
0. Thus, it shouldn't cause error=maybe-uninitialized. This patch
explicitly initializes it to 0 in case a (incapable) compiler
complains about it.
BUG=b:182600604, b:173235954
BRANCH=none
TEST=make utils-host
Change-Id: Ifff972c32007a573ac7cf759387edeb382dccaa4
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2966802
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/ectool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/ectool.c b/util/ectool.c index 80f7ebc267..36c368372a 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -9657,7 +9657,7 @@ static int cmd_pchg(int argc, char *argv[]) * ... */ uint32_t address, version; - uint32_t block_size; + uint32_t block_size = 0; uint32_t crc; int i; @@ -9674,7 +9674,7 @@ static int cmd_pchg(int argc, char *argv[]) } rv = cmd_pchg_update_open(port, version, &block_size, &crc); - if (rv < 0) { + if (rv < 0 || block_size == 0) { fprintf(stderr, "\nFailed to open update session: %d\n", rv); return -1; |