diff options
author | Randall Spangler <rspangler@chromium.org> | 2012-09-25 15:28:55 -0700 |
---|---|---|
committer | Gerrit <chrome-bot@google.com> | 2012-09-26 11:31:31 -0700 |
commit | 5943e6c1f5ca86c96cfa38926651466d929278d2 (patch) | |
tree | 13b1c4610e16abbfe55cc1d1f16559d69fe6c452 /util | |
parent | 1b14b2c922808ac1f7084f301d54173ca0074bf7 (diff) | |
download | chrome-ec-5943e6c1f5ca86c96cfa38926651466d929278d2.tar.gz |
Clean up reboot host command
1) Only send the host response immediately for commands which won't
return. This prevents double-sending a response for the disable-jump
command.
2) Remove references to the POWER_ON flag. This was never implemented
or used, since with EC software sync the EC always powers on after
rebooting.
3) Fix help text for reboot_ec command. (Both "A" and "RW" still do the
same thing, but "RW" is now the preferred option string.)
BUG=chrome-os-partner:12635
BRANCH=link (also applies to snow, but don't pick unless needed)
TEST=from a root shell,
flashrom -p internal:bus=lpc -r /tmp/ec.bin
flashrom -p internal:bus=lpc -w /tmp/ec.bin
ectool reboot_ec RW
ectool reboot_ec RO
ectool disable-jump
All commands should succeed.
Change-Id: Ibf5b4fb88d93e64fc7361a9f962ec7aa1df0cf3c
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/34051
Reviewed-by: Yung-Chieh Lo <yjlou@chromium.org>
Diffstat (limited to 'util')
-rw-r--r-- | util/ectool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/ectool.c b/util/ectool.c index 7ddaa07c06..f281fd62ac 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -110,7 +110,7 @@ const char help_str[] = " Set keyboard backlight in percent\n" " readtest <patternoffset> <size>\n" " Reads a pattern from the EC via LPC\n" - " reboot_ec <RO|A|disable-jump> [at-shutdown]\n" + " reboot_ec <RO|RW|disable-jump> [at-shutdown]\n" " Reboot EC to RO or RW\n" " rtcget\n" " Print real-time clock\n" |