diff options
| author | Yuval Peress <peress@chromium.org> | 2021-08-04 11:19:55 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-20 14:32:44 +0000 |
| commit | 8270698e589f14239b4942a42b27132af497410b (patch) | |
| tree | ea10c53f412c229980ea24a6faf8572295b92f75 /zephyr/shim/src/system.c | |
| parent | d63ba9739b77bece9e0be136dd256c89ce2fd688 (diff) | |
| download | chrome-ec-8270698e589f14239b4942a42b27132af497410b.tar.gz | |
system: fix system_get_scratchpad API
The current API for system_get_scratchpad mixes the status and the value
being read. Update the signature to allow both.
BRANCH=none
BUG=b:195481980
TEST=make testall && zmake testall
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I3a5f5ad523d507c53a5d474806f58afafb82e70c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3074828
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'zephyr/shim/src/system.c')
| -rw-r--r-- | zephyr/shim/src/system.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/zephyr/shim/src/system.c b/zephyr/shim/src/system.c index 5a9612fa26..d6af88a9ff 100644 --- a/zephyr/shim/src/system.c +++ b/zephyr/shim/src/system.c @@ -109,23 +109,19 @@ int system_set_scratchpad(uint32_t value) GET_BBRAM_SIZE(scratchpad), (uint8_t *)&value); } -uint32_t system_get_scratchpad(void) +int system_get_scratchpad(uint32_t *value) { - uint32_t value; - if (bbram_dev == NULL) { LOG_ERR("bbram_dev doesn't binding"); - /* - * TODO(b/195481980): Seperate the scratchpad value & API - * status. - */ - return 0; + return -EC_ERROR_INVAL; } - cros_bbram_read(bbram_dev, GET_BBRAM_OFFSET(scratchpad), - GET_BBRAM_SIZE(scratchpad), (uint8_t *)&value); + if (cros_bbram_read(bbram_dev, GET_BBRAM_OFFSET(scratchpad), + GET_BBRAM_SIZE(scratchpad), (uint8_t *)value)) { + return -EC_ERROR_INVAL; + } - return value; + return 0; } void system_hibernate(uint32_t seconds, uint32_t microseconds) |