diff options
| author | Andrew McRae <amcrae@google.com> | 2022-03-04 00:39:50 +1100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-03-07 07:25:13 +0000 |
| commit | 85642876c8284e59055eafcde3328c76141e3b57 (patch) | |
| tree | 59e9ec851b70a4d503314a510f5af42be35a2eef /zephyr/subsys/ap_pwrseq/signal_gpio.c | |
| parent | bc4bd9d0f50b01a95391a09e9b828a389a075a65 (diff) | |
| download | chrome-ec-85642876c8284e59055eafcde3328c76141e3b57.tar.gz | |
zephyr: Initialise power signal GPIO outputs to deasserted state
Ensure that power signal GPIO outputs have an explicit
setting by default to a deasserted state.
BUG=b:222468059
TEST=zmake testall
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: Iecb70ef2eaf54b10d33785f07d23a20b5d873923
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3499711
Reviewed-by: Divya S Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Diffstat (limited to 'zephyr/subsys/ap_pwrseq/signal_gpio.c')
| -rw-r--r-- | zephyr/subsys/ap_pwrseq/signal_gpio.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/zephyr/subsys/ap_pwrseq/signal_gpio.c b/zephyr/subsys/ap_pwrseq/signal_gpio.c index e6eb433072..a130bc8abf 100644 --- a/zephyr/subsys/ap_pwrseq/signal_gpio.c +++ b/zephyr/subsys/ap_pwrseq/signal_gpio.c @@ -23,8 +23,8 @@ DT_FOREACH_STATUS_OKAY(MY_COMPAT, INIT_GPIO_SPEC) */ struct ps_gpio_int { gpio_flags_t flags; - uint8_t output; - uint8_t no_enable; + unsigned output : 1; + unsigned no_enable : 1; }; #define INIT_GPIO_CONFIG(id) \ @@ -114,7 +114,8 @@ void power_signal_gpio_init(void) { for (int i = 0; i < ARRAY_SIZE(gpio_config); i++) { if (gpio_config[i].output) { - gpio_pin_configure_dt(&spec[i], GPIO_OUTPUT); + /* Init to deasserted state */ + gpio_pin_configure_dt(&spec[i], GPIO_OUTPUT_INACTIVE); } else { gpio_pin_configure_dt(&spec[i], GPIO_INPUT); /* If interrupt, initialise it */ |