summaryrefslogtreecommitdiff
path: root/zephyr/test
diff options
context:
space:
mode:
authorPatryk Duda <pdk@semihalf.com>2021-09-01 11:38:53 +0000
committerCommit Bot <commit-bot@chromium.org>2021-09-07 19:40:53 +0000
commit968b86d63a578e72c2c9de8e6f5d2acb27cce9fa (patch)
treeae1249a707a23e5fc79daf6c99d455d251058cbe /zephyr/test
parentbdb805bc222ae41a762bc5dbf6ac281fd0a00047 (diff)
downloadchrome-ec-968b86d63a578e72c2c9de8e6f5d2acb27cce9fa.tar.gz
fpsensor: Propagate no match auth code when finger outside range
When fp_finger_match() function returns code which indicates that match failed it also sets number of matched template to -1. Until now, in fp_process_match() we set internal error code when finger number was invalid (fgr variable was set to -1). This resulted in overwriting MATCH_NO, MATCH_LOW_QUALITY, MATCH_LOW_COVERAGE with MATCH_NO_INTERNAL error code when match failed. As a result, biod was receiving only internal errors always when match failed. Now we overwrite error code with internal error only when fp_finger_match() returns negative value or when it returns success, but finger template number is outside range. In other cases we pass unchanged error code to biod. BUG=b:184843581 BRANCH=none TEST=Flash FPMCU firmware on Chromebook. Reboot Chromebook, make sure your firmware is running. Cover up part of sensor with paper and try to unlock device. Compare biod and cros_fp logs, make sure that biod reports the same reason on failed attempts. Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I64e6cb2850c0bf4700482c35899f23b8102a480b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3135425 Tested-by: Patryk Duda <patrykd@google.com> Commit-Queue: Patryk Duda <patrykd@google.com> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Diffstat (limited to 'zephyr/test')
0 files changed, 0 insertions, 0 deletions