diff options
| author | Jack Rosenthal <jrosenth@chromium.org> | 2023-01-06 14:55:11 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-01-06 23:22:04 +0000 |
| commit | 75adf91349979092faa3f09ebeeef8078224dde2 (patch) | |
| tree | 74a931ba8294f777fe61699d6d425b424666c52f /zephyr/zmake | |
| parent | 359da8c36b1996b2f59d60d86ef89a08e1cd040b (diff) | |
| download | chrome-ec-75adf91349979092faa3f09ebeeef8078224dde2.tar.gz | |
zmake: Fix cmake_defs for build and compare-builds subcommands
This was implemented for the configure subcommand, but since the
keyword arguments were missing for the build and compare_builds
methods for cmake_defs, these flags were not being applied.
BUG=b:259306777
BRANCH=i don't care
TEST=zmake -D build minimal-posix -DSOMETHING=ANOTHER
~> the cmake command shows the variable passed
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I538549e01a157b8f4c9ac4e687e4eb88c2c00c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4143808
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Diffstat (limited to 'zephyr/zmake')
| -rw-r--r-- | zephyr/zmake/zmake/zmake.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/zephyr/zmake/zmake/zmake.py b/zephyr/zmake/zmake/zmake.py index 41d3c2ce94..1c1dcfb36c 100644 --- a/zephyr/zmake/zmake/zmake.py +++ b/zephyr/zmake/zmake/zmake.py @@ -306,6 +306,7 @@ class Zmake: clobber=False, bringup=False, coverage=False, + cmake_defs=None, allow_warnings=False, all_projects=False, extra_cflags=None, @@ -321,6 +322,7 @@ class Zmake: clobber=clobber, bringup=bringup, coverage=coverage, + cmake_defs=cmake_defs, allow_warnings=allow_warnings, all_projects=all_projects, extra_cflags=extra_cflags, @@ -339,6 +341,7 @@ class Zmake: all_projects=False, extra_cflags=None, keep_temps=False, + cmake_defs=None, ): """Compare EC builds at two commits.""" temp_dir = tempfile.mkdtemp(prefix="zcompare-") @@ -382,6 +385,7 @@ class Zmake: clobber=False, bringup=False, coverage=False, + cmake_defs=cmake_defs, allow_warnings=False, all_projects=all_projects, extra_cflags=extra_cflags, |