summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--chip/g/upgrade_fw.h1
-rw-r--r--extra/rma_reset/rma_reset.c2
-rw-r--r--extra/usb_updater/gsctool.c5
-rw-r--r--include/rma_auth.h2
-rw-r--r--include/tpm_vendor_cmds.h2
5 files changed, 6 insertions, 6 deletions
diff --git a/chip/g/upgrade_fw.h b/chip/g/upgrade_fw.h
index 1c5dc7290a..d3414b103e 100644
--- a/chip/g/upgrade_fw.h
+++ b/chip/g/upgrade_fw.h
@@ -8,6 +8,7 @@
#include <stddef.h>
+#include "common.h" /* For __packed. */
/*
* This file contains structures used to facilitate cr50 firmware updates,
diff --git a/extra/rma_reset/rma_reset.c b/extra/rma_reset/rma_reset.c
index 17a2539c41..efbb1b8850 100644
--- a/extra/rma_reset/rma_reset.c
+++ b/extra/rma_reset/rma_reset.c
@@ -13,7 +13,7 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
-#define __packed __attribute__((packed))
+
#include "rma_auth.h"
#include "curve25519.h"
#include "sha256.h"
diff --git a/extra/usb_updater/gsctool.c b/extra/usb_updater/gsctool.c
index de26319271..035fb373ac 100644
--- a/extra/usb_updater/gsctool.c
+++ b/extra/usb_updater/gsctool.c
@@ -20,11 +20,6 @@
#include <termios.h>
#include <unistd.h>
-
-#ifndef __packed
-#define __packed __attribute__((packed))
-#endif
-
#include "config.h"
#include "ccd_config.h"
diff --git a/include/rma_auth.h b/include/rma_auth.h
index 088e8b6467..427e5c90de 100644
--- a/include/rma_auth.h
+++ b/include/rma_auth.h
@@ -10,6 +10,8 @@
#include <stdint.h>
+#include "common.h" /* For __packed. */
+
/* Current challenge protocol version */
#define RMA_CHALLENGE_VERSION 0
diff --git a/include/tpm_vendor_cmds.h b/include/tpm_vendor_cmds.h
index b61ca2623c..8300260795 100644
--- a/include/tpm_vendor_cmds.h
+++ b/include/tpm_vendor_cmds.h
@@ -6,6 +6,8 @@
#ifndef __INCLUDE_TPM_VENDOR_CMDS_H
#define __INCLUDE_TPM_VENDOR_CMDS_H
+#include "common.h" /* For __packed. */
+
/*
* This file includes definitions of extended/vendor TPM2 commands and their
* return codes. The definitions are shared between the embedded code and the