diff options
| -rw-r--r-- | common/i2c_master.c | 2 | ||||
| -rw-r--r-- | util/ectool.c | 27 |
2 files changed, 20 insertions, 9 deletions
diff --git a/common/i2c_master.c b/common/i2c_master.c index c010dd1915..74ae1db216 100644 --- a/common/i2c_master.c +++ b/common/i2c_master.c @@ -710,7 +710,7 @@ static int check_i2c_params(const struct host_cmd_handler_args *args) msgnum++, msg++) { unsigned int addr_flags = msg->addr_flags; - PTHRUPRINTS("port=%d, %s, addr=0x%x, len=%d", + PTHRUPRINTS("port=%d, %s, addr=0x%x(7-bit), len=%d", params->port, addr_flags & EC_I2C_FLAG_READ ? "read" : "write", addr_flags & EC_I2C_ADDR_MASK, diff --git a/util/ectool.c b/util/ectool.c index 76f3c2cc18..32fe0092c3 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -6067,6 +6067,22 @@ int do_i2c_xfer(unsigned int port, unsigned int addr, return 0; } +static void cmd_i2c_help(void) +{ + fprintf(stderr, + " Usage: i2cread <8 | 16> <port> <addr8> <offset>\n" + " Usage: i2cwrite <8 | 16> <port> <addr8> <offset> <data>\n" + " Usage: i2cxfer <port> <addr7> <read_count> [bytes...]\n" + " <port> i2c port number\n" + " <addr8> 8-bit i2c address\n" + " <addr7> 7-bit i2c address\n" + " <offset> offset to read from or write to\n" + " <data> data to write\n" + " <read_count> number of bytes to read\n" + " [bytes ...] data to write\n" + ); + +} int cmd_i2c_read(int argc, char *argv[]) { @@ -6078,8 +6094,7 @@ int cmd_i2c_read(int argc, char *argv[]) int rv; if (argc != 5) { - fprintf(stderr, "Usage: %s <8 | 16> <port> <addr> <offset>\n", - argv[0]); + cmd_i2c_help(); return -1; } @@ -6131,9 +6146,7 @@ int cmd_i2c_write(int argc, char *argv[]) int rv; if (argc != 6) { - fprintf(stderr, - "Usage: %s <8 | 16> <port> <addr> <offset> <data>\n", - argv[0]); + cmd_i2c_help(); return -1; } @@ -6191,9 +6204,7 @@ int cmd_i2c_xfer(int argc, char *argv[]) int rv, i; if (argc < 4) { - fprintf(stderr, - "Usage: %s <port> <slave_addr> <read_count> " - "[write bytes...]\n", argv[0]); + cmd_i2c_help(); return -1; } |