diff options
-rw-r--r-- | board/galtic/board.c | 14 | ||||
-rw-r--r-- | board/magolor/board.c | 25 | ||||
-rw-r--r-- | board/metaknight/board.c | 25 | ||||
-rw-r--r-- | board/sasuke/board.c | 25 | ||||
-rw-r--r-- | board/waddledoo/board.c | 25 |
5 files changed, 30 insertions, 84 deletions
diff --git a/board/galtic/board.c b/board/galtic/board.c index 01c2932f4c..8eea397f0c 100644 --- a/board/galtic/board.c +++ b/board/galtic/board.c @@ -464,14 +464,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - *kp = 3; - *kp_div = 14; - - *ki = 3; - *ki_div = 500; - - *kd = 4; - *kd_div = 40; + *kp = 1; + *kp_div = 20; + *ki = 1; + *ki_div = 250; + *kd = 0; + *kd_div = 1; } __override void typec_set_source_current_limit(int port, enum tcpc_rp_value rp) diff --git a/board/magolor/board.c b/board/magolor/board.c index fd4149aaf2..fce00baf1e 100644 --- a/board/magolor/board.c +++ b/board/magolor/board.c @@ -698,25 +698,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - /* - * Early boards need different constants due to a change in charger IC - * silicon revision. - */ - if (system_get_board_version() >= 0) { - *kp = 1; - *kp_div = 128; - *ki = 1; - *ki_div = 1024; - *kd = 0; - *kd_div = 1; - } else { - *kp = 1; - *kp_div = 4; - *ki = 1; - *ki_div = 15; - *kd = 1; - *kd_div = 10; - } + *kp = 1; + *kp_div = 20; + *ki = 1; + *ki_div = 250; + *kd = 0; + *kd_div = 1; } int pd_snk_is_vbus_provided(int port) diff --git a/board/metaknight/board.c b/board/metaknight/board.c index a99499695c..4bd8404392 100644 --- a/board/metaknight/board.c +++ b/board/metaknight/board.c @@ -714,25 +714,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - /* - * Early boards need different constants due to a change in charger IC - * silicon revision. - */ - if (system_get_board_version() >= 0) { - *kp = 1; - *kp_div = 128; - *ki = 1; - *ki_div = 1024; - *kd = 0; - *kd_div = 1; - } else { - *kp = 1; - *kp_div = 4; - *ki = 1; - *ki_div = 15; - *kd = 1; - *kd_div = 10; - } + *kp = 1; + *kp_div = 20; + *ki = 1; + *ki_div = 250; + *kd = 0; + *kd_div = 1; } int pd_snk_is_vbus_provided(int port) diff --git a/board/sasuke/board.c b/board/sasuke/board.c index 962f4a6bab..39223fc60c 100644 --- a/board/sasuke/board.c +++ b/board/sasuke/board.c @@ -392,25 +392,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - /* - * Early boards need different constants due to a change in charger IC - * silicon revision. - */ - if (system_get_board_version() >= 0) { - *kp = 1; - *kp_div = 128; - *ki = 1; - *ki_div = 1024; - *kd = 0; - *kd_div = 1; - } else { - *kp = 1; - *kp_div = 4; - *ki = 1; - *ki_div = 15; - *kd = 1; - *kd_div = 10; - } + *kp = 1; + *kp_div = 20; + *ki = 1; + *ki_div = 250; + *kd = 0; + *kd_div = 1; } int pd_snk_is_vbus_provided(int port) diff --git a/board/waddledoo/board.c b/board/waddledoo/board.c index cdfe78a379..bea0774a3d 100644 --- a/board/waddledoo/board.c +++ b/board/waddledoo/board.c @@ -507,25 +507,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - /* - * Early boards need different constants due to a change in charger IC - * silicon revision. - */ - if (system_get_board_version() >= 0) { - *kp = 1; - *kp_div = 128; - *ki = 1; - *ki_div = 1024; - *kd = 0; - *kd_div = 1; - } else { - *kp = 1; - *kp_div = 4; - *ki = 1; - *ki_div = 15; - *kd = 1; - *kd_div = 10; - } + *kp = 1; + *kp_div = 20; + *ki = 1; + *ki_div = 250; + *kd = 0; + *kd_div = 1; } int pd_snk_is_vbus_provided(int port) |