diff options
Diffstat (limited to 'chip/ish')
| -rw-r--r-- | chip/ish/ipc_heci.c | 10 | ||||
| -rw-r--r-- | chip/ish/system_state_subsys.c | 6 |
2 files changed, 2 insertions, 14 deletions
diff --git a/chip/ish/ipc_heci.c b/chip/ish/ipc_heci.c index 9e62c33520..cce3298f01 100644 --- a/chip/ish/ipc_heci.c +++ b/chip/ish/ipc_heci.c @@ -448,10 +448,7 @@ static void ipc_host2ish_isr(void) uint32_t pimr = IPC_PIMR; /* - * TODO(b/122364080): Remove this code once proper power management is - * in place for ISH. - * - * Ensure that the host IPC power is requested after getting an + * Ensure that the host IPC write power is requested after getting an * interrupt otherwise the resume message will never get delivered (via * host ipc communication). Resume is where we would like to restore all * power settings, but that is too late for this power request. @@ -687,10 +684,7 @@ void ipc_mng_task(void) ipc_handle_t handle; /* - * TODO(b/122364080): Remove this code once proper power management is - * in place for ISH. - * - * Ensure that power for host IPCs is requested and ack'ed + * Ensure that power for host IPC writes is requested and ack'ed */ if (IS_ENABLED(CHIP_FAMILY_ISH5)) { PMU_VNN_REQ = VNN_REQ_IPC_HOST_WRITE & ~PMU_VNN_REQ; diff --git a/chip/ish/system_state_subsys.c b/chip/ish/system_state_subsys.c index 93539d2ddf..36b79c747a 100644 --- a/chip/ish/system_state_subsys.c +++ b/chip/ish/system_state_subsys.c @@ -107,9 +107,6 @@ static int ss_subsys_suspend(void) } /* - * TODO(b/122364080): Remove this code once proper power management is - * in place for ISH. - * * PMU_VNN_REQ is used by ISH FW to assert power requirements of ISH to * PMC. The system won't enter S0ix if ISH is requesting any power * rails. Setting a bit to 1 both sets and clears a requested value. @@ -127,9 +124,6 @@ static int ss_subsys_resume(void) int i; /* - * TODO(b/122364080): Remove this code once proper power management is - * in place for ISH. - * * Restore VNN power request from before suspend. */ if (IS_ENABLED(CHIP_FAMILY_ISH5) && |