diff options
Diffstat (limited to 'driver/tcpm')
| -rw-r--r-- | driver/tcpm/tusb422.c | 15 | ||||
| -rw-r--r-- | driver/tcpm/tusb422.h | 3 |
2 files changed, 10 insertions, 8 deletions
diff --git a/driver/tcpm/tusb422.c b/driver/tcpm/tusb422.c index 511c18853f..7910b8b2de 100644 --- a/driver/tcpm/tusb422.c +++ b/driver/tcpm/tusb422.c @@ -51,11 +51,16 @@ static int tusb422_tcpci_tcpm_init(int port) { int rv; - /* TUSB422 has a vendor-defined register reset */ - rv = tcpc_update8(port, TUSB422_REG_CC_GEN_CTRL, - TUSB422_REG_CC_GEN_CTRL_GLOBAL_SW_RST, MASK_SET); - if (rv) - return rv; + /* + * Do not perform TCPC soft reset while waking from Low Power Mode, + * because it makes DRP incapable of looking for connection correctly + * (see b/176986511) and probably breaks firmware_PDTrySrc test + * (see b/179234089). + * + * TODO(b/179234089): Consider implementing function that performs + * only necessary things when leaving Low Power Mode, so we can perform + * TCPC soft reset here. + */ rv = tcpci_tcpm_init(port); if (rv) diff --git a/driver/tcpm/tusb422.h b/driver/tcpm/tusb422.h index 3d2006b2c3..f39939b184 100644 --- a/driver/tcpm/tusb422.h +++ b/driver/tcpm/tusb422.h @@ -16,9 +16,6 @@ #define TUSB422_REG_VENDOR_INTERRUPTS_MASK 0x92 #define TUSB422_REG_VENDOR_INTERRUPTS_MASK_FRS_RX BIT(0) -#define TUSB422_REG_CC_GEN_CTRL 0x94 -#define TUSB422_REG_CC_GEN_CTRL_GLOBAL_SW_RST BIT(5) - #define TUSB422_REG_PHY_BMC_RX_CTRL 0x96 #define TUSB422_REG_PHY_BMC_RX_CTRL_FRS_RX_EN BIT(3) |