summaryrefslogtreecommitdiff
path: root/zephyr/test/drivers/default/src/console_cmd/charge_state.c
diff options
context:
space:
mode:
Diffstat (limited to 'zephyr/test/drivers/default/src/console_cmd/charge_state.c')
-rw-r--r--zephyr/test/drivers/default/src/console_cmd/charge_state.c34
1 files changed, 22 insertions, 12 deletions
diff --git a/zephyr/test/drivers/default/src/console_cmd/charge_state.c b/zephyr/test/drivers/default/src/console_cmd/charge_state.c
index 7ee91049ae..8cfd11324f 100644
--- a/zephyr/test/drivers/default/src/console_cmd/charge_state.c
+++ b/zephyr/test/drivers/default/src/console_cmd/charge_state.c
@@ -3,9 +3,6 @@
* found in the LICENSE file.
*/
-#include <zephyr/shell/shell.h>
-#include <zephyr/ztest.h>
-
#include "charge_state.h"
#include "charge_state_v2.h"
#include "console.h"
@@ -13,6 +10,9 @@
#include "test/drivers/test_state.h"
#include "test/drivers/utils.h"
+#include <zephyr/shell/shell.h>
+#include <zephyr/ztest.h>
+
ZTEST_USER(console_cmd_charge_state, test_idle_too_few_args)
{
int rv;
@@ -116,7 +116,7 @@ ZTEST_USER(console_cmd_charge_state, test_debug_on_show_charging_progress)
charging_progress_displayed();
/* Enable debug printing */
- zassume_ok(shell_execute_cmd(get_ec_shell(), "chgstate debug on"),
+ zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate debug on"),
NULL);
/* Sleep at least 1 full iteration of the charge state loop */
@@ -159,6 +159,16 @@ ZTEST_USER(console_cmd_charge_state, test_sustain_invalid_params)
zassert_equal(shell_execute_cmd(get_ec_shell(),
"chgstate sustain 50 101"),
EC_ERROR_INVAL, NULL);
+
+ /* Verify invalid lower bound (not a number) */
+ zassert_equal(shell_execute_cmd(get_ec_shell(),
+ "chgstate sustain a 50"),
+ EC_ERROR_PARAM2);
+
+ /* Verify invalid uppoer bound (not a number) */
+ zassert_equal(shell_execute_cmd(get_ec_shell(),
+ "chgstate sustain 30 a"),
+ EC_ERROR_PARAM3);
}
struct console_cmd_charge_state_fixture {
@@ -206,7 +216,7 @@ ZTEST_USER_F(console_cmd_charge_state, test_idle_on_from_normal)
fixture->tcpci_emul, fixture->charger_emul);
/* Verify that we're in "normal" mode */
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
/* Move to idle */
zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate idle on"));
@@ -220,11 +230,11 @@ ZTEST_USER_F(console_cmd_charge_state, test_normal_from_idle)
fixture->tcpci_emul, fixture->charger_emul);
/* Verify that we're in "normal" mode */
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
/* Move to idle */
- zassume_ok(shell_execute_cmd(get_ec_shell(), "chgstate idle on"));
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_IDLE);
+ zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate idle on"));
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_IDLE);
/* Move back to normal */
zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate idle off"),
@@ -239,7 +249,7 @@ ZTEST_USER_F(console_cmd_charge_state, test_discharge_on)
fixture->tcpci_emul, fixture->charger_emul);
/* Verify that we're in "normal" mode */
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
/* Enable discharge */
zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate discharge on"),
@@ -254,12 +264,12 @@ ZTEST_USER_F(console_cmd_charge_state, test_discharge_off)
fixture->tcpci_emul, fixture->charger_emul);
/* Verify that we're in "normal" mode */
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_NORMAL);
/* Enable discharge */
- zassume_ok(shell_execute_cmd(get_ec_shell(), "chgstate discharge on"),
+ zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate discharge on"),
NULL);
- zassume_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_DISCHARGE);
+ zassert_equal(get_chg_ctrl_mode(), CHARGE_CONTROL_DISCHARGE);
/* Disable discharge */
zassert_ok(shell_execute_cmd(get_ec_shell(), "chgstate discharge off"),