| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=None
BUG=b:253647573
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I1f91b8123a2e44ea5a137f9644645ca1b4494aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3956204
Reviewed-by: Bobby Casey <bobbycasey@google.com>
Commit-Queue: Bobby Casey <bobbycasey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some test files that were not getting excluded by the test
filter. Most importantly, some tests are mixed into the same
directories, but named _test.c.
BRANCH=None
BUG=None
TEST=./firmware_builder.py --code-coverage test
lcov --list-full-path --list build/zephyr/lcov_no_tests.info | \
sed -e 's|/mnt/host/source/src/||' | egrep 'mock|emul|test|host'
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I4d8335c4185ba373f93fbfe6bf2ed99aaa7a0ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3957418
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new tool to merge lcov files using one file as the template and
including only lines that are present in the template file.
The name is because you use the template file like a "stencil" and the
matching coverage shows through. Not great, but it's not really a
"set intersect" or a "merge" either.
Switch firmware_builder.py and gitlab to use the new tool in place of
the filename filtering.
See
https://jbettis.users.x20web.corp.google.com/www/herobrine_rpt/index.html
for updated coverage output.
BRANCH=None
BUG=None
TEST=Ran firmware_builder.py locally.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I0e9672c346971b0df4602b0adce27fea6367c6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3943261
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add krabby, nivviks, and skyrim specific coverage builds to cq and
gitlab. In cq this is just lcov commands, no new builds will actually
be run.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I59120b9a2b7cff7fbe5f7d24c92a4c877ccd79b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3936944
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The retries weren't actually working because $? was getting set by the
echo call.
BRANCH=None
BUG=b:244590155
TEST=Ran sh commands manually
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I3b8a7133e260f052df00950a139aee4613fa102c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3908158
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the legacy ec build, set the host compiler prefix also.
BRANCH=None
BUG=b:246424843
TEST=make test-coverage # in gitlab docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie3fc01fe055152e0150ad2180b648963d77c1ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3905359
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Al Semjonovs <asemjonovs@google.com>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The zephyr_boards_coverage job sometimes times out after 2 hours. While
I think I fixed the problem with the slow runner, splitting this into
shards is also a good idea.
BRANCH=None
BUG=b:244590155
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/640483665
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If37d2ddcbd64c4f2b7e7ab240e75218ed24aece0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3896634
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the cache, since it only works with shared runners, but keep the
needs tags or else Gitlab will run all the build stage jobs before
starting any of the test stage jobs, and that is slower.
Get the timestamp of the latest commit, and use that timestamp to
checkout the corresponding cls in the zephyr and ancillary repos.
Retry git clone calls because they actually fail pretty often.
BRANCH=None
BUG=b:244590155
TEST=Pushed to gitlab coverage branch
https://gitlab.com/zephyr-ec/ec/-/pipelines/640483665
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie66d5c97349ef17eba302387c3cd525dfbaa82ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894402
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name & style.
BRANCH=none
BUG=chromium:1098010
TEST=`repo upload` works
Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pyelftools isn't working with the new GCC in SDK 0.15, so just allow it
to fail, since it is informational only and we still have reports
working in the CQ.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I37e1e893d007e705b0d8dfda85c09d1978cd5dc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3886889
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We had pyelftools 0.26 installed, and need 0.28. Probably this should
be in the DockerFile, but this is faster.
BRANCH=None
BUG=None
TEST=Ran pip in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iaa9ddd4dcddf696eb4d59b8a6cffb4e33e1c1ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3885228
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Tomasz Michalec <tmichalec@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Tomasz Michalec <tmichalec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zephyr requires the sdk 0.15 or newer now.
BRANCH=None
BUG=None
TEST=Pushed to gitlab
https://gitlab.com/zephyr-ec/ec/-/pipelines/633794126
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id802efcdeb9f391cd02f93aec923fd6c5764e854
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3880533
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This workflow rule will prevent this CI config from running unless the
branch name is "main" or "coverage". It will have to be cherry-picked
into all the other branches to make them stop running sadly.
BRANCH=None
BUG=b:244766499
TEST=Used yaml validator at
https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I536de3e3fdbca1c48505e61de5737f865bd0e233
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872545
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch twister wrapper to use vpython to force it to use python 3.8 with
the right modules.
BRANCH=None
BUG=b:244333401
TEST=./twister
Change-Id: I4d020f4082b7c6e987bc4aa3aee6335760a27efa
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867800
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the EC dir wasn't moving the dot files, also deleting the files
from the cache defeats the purpose of the cache.
Corrected both problems.
BRANCH=None
BUG=None
TEST=Pushed to coverage branch in gitlab.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I2920ec27eafdc76248e9253724b29a198262865a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3869307
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL aims to get Twister working in the Gitlab CI using a GCC
toolchain. It also includes some cleanup of the directory structure and
paths in the CI build. The previous approach of checking out zephyr and
all zephyr modules as subdirectories under the EC checkout breaks the
way Twister searches for tests, as all upstream Zephyr tests get
included when we search the EC dir. A detailed layout of the new
directory structure is included as a comment in the YAML file.
Also bumps up the timeout on several driver tests as they were timing
out in CI.
BRANCH=None
BUG=None
TEST=gitlab-runner exec ... {ec_coverage, zephyr_coverage,
zephyr_boards_coverage}
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: I80697bd02be363d8462f48abc4b6f0a2394a8926
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3846994
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running twister, run both the EC tests and the zephyr shell tests
by default. This should provide for more consistent coverage of the
shell code.
BRANCH=None
BUG=b:242108457
TEST=./twister
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I25078ee0a375de18afaab6a3bfc1ffc8b47b6b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3829060
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add -p unit_testing to coverage run of twister in case we get some unit
tests.
Remove --coverage and platforms from testall stage.
Add -v -i to both twister calls so that we get better logs.
BRANCH=None
BUG=b:242067297
TEST=Ran cmds in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I2013105222b13cbfae75af355ee6d69d353d85b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3823905
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Install ply python module.
BRANCH=None
BUG=b:242067381
TEST=Ran twister in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I71571cef7679852f28b5ca5a598b96d6f11de2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3823904
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the host gcov correctly, if we are using gcc, then use gcov,
otherwise use llvm-cov for clang.
Remove the workaround in .gitlab-ci.yml
BRANCH=None
BUG=None
TEST=make clobber && make TEST_FLAG=TEST_COVERAGE=y \
build/coverage/usb_pe_drp_noextended.info V=1 CC=clang
TEST=make clobber && make TEST_FLAG=TEST_COVERAGE=y \
build/coverage/usb_pe_drp_noextended.info V=1
TEST=(in docker) make -j8 CRYPTOC_DIR="${MODULES_DIR}/cryptoc" \
CROSS_COMPILE_arm=/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi- \
TEST_FLAG=TEST_COVERAGE=y build/coverage/usb_pe_drp_noextended.info V=1
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ic97d425e35e25bea07e29c4736730fd21dd72f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3818125
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have completed transitioning tests to Twister and verified parity in
coverage reports between this and the previous version. This CL
removes the BUILD.py files from our tests that declare the zmake
projects and removes the call to `zmake -D test -a --no-rebuild` from
`zephyr/firmware-builder.py` The `EC_ZEPHYR_MERGED` metric is now
derived from Twister's coverage data instead. Made corresponding changes
to `.gitlab-ci.yml`
This CL was tested by comparing the total coverage and list of covered
files before and after the change.
BUG=b:240093007
BRANCH=None
TEST=zephyr/firmware-builder.py --code-coverage {build|test|bundle}
Signed-off-by: Tristan Honscheid <honscheid@google.com>
Change-Id: I865a22a44f56760790444499c7588f7aec299374
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3811956
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The posix-ec project was renamed, and it was really only a sample, so
just remove it from here. The target zephyr_boards_coverage will still
build it, so we're not really losing anything by removing it.
BUG=b:237431976
BRANCH=none
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If7d006885b38fec97bd234bcb4b250bf74e4c6c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3736985
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gitlab builder is running out of disk space. Add flags to build
fewer things, and to delete the intermediate files and only leave the
output files.
Before this change zmake build of all boards took 2.1G, and 81M
afterwards.
BRANCH=None
BUG=None
TEST=make clobber
TEST=zmake build --boards-only -c --delete-intermediates
TEST=du -s -h build
Change-Id: I507abff512ca1348681a1fd7431d5267efaf5d65
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3726959
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that zmake defaults to the physical number of cpus, don't use -j8.
BRANCH=None
BUG=None
TEST=git cherrypick to gitlab
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If4049ed7a015680b35127b92c2fd49070c648d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3652378
Reviewed-by: Yuval Peress <peress@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new coverage report to the merged_coverage job, which is all
zephyr boards merged with EC and Zephyr tests (but not twister). This
will be a more useful report for tracking coverage increases or
regressions as it will include all boards not just herobrine.
BRANCH=None
BUG=None
TEST=Pushed to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id9c879ade22f7a53973bcea90b604250db92ddd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3652377
Reviewed-by: Yuval Peress <peress@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were filtering out some directories that are impossible to test with
coverage right now from the tests, but not from the boards.
Change filters to match in all 3 places.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I17ff82e277069ecddb7c61b61e9ba089a3c54cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3632182
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Volteer was the first reference board with EC based on Zephyr. At this
stage of migrating to Zephyr, the support for Volteer can be dropped, so
remove volteer project.
BUG=b:218888909
TEST=zmake testall
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Ie78cc69e478267f45446b9d11fc2f433136ebfe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521781
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In zmake, don't remove any directories from the coverage reports.
In gitlab, add the exclusions back in so that we get the same finished
html report that we got before.
BRANCH=None
BUG=b:156895937
TEST=Ran firmware_builder.py, verified zephyr/test & zephyr/emul
Ran .gitlab-ci.yml commands for herobrine and verified that
build/herobrine/output/filtered_no_zephyr.info is unchanged.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie8fd1e787d8bb6e745f89d773113cccb6c335009
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491416
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables support for testing U-Boot vboot.
BUG=b:209799513
BRANCH=none
TEST=passes on gitlab:
https://gitlab.com/zephyr-ec/ec/-/pipelines/479753623
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I4a94ec7f08236a85b544f7eb73ce277993670af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491075
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The regex wasn't matching the TOTAL line from the coverage report.
Change to the recommended regex from
https://docs.gitlab.com/ee/ci/pipelines/settings.html#test-coverage-examples
BRANCH=None
BUG=b:219062927
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia867148e95f0aa5de3a7e182a13cce952f4b114f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489261
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change all zmake invocations to use -j8, since it defaults to -j1, and
change the testall step to only build and run the tests.
BRANCH=None
BUG=b:217788621
TEST=None
Change-Id: Id8892ea5e37796da048573509cc17553dd8d0921
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488788
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new commands to run zmake unit tests with coverage enabled.
BRANCH=None
BUG=b:219062927
TEST=Ran commands in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie7e8c0a33df8e92ff946e87bb787dd4a0aced2fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3472820
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in go/zmake-cli-v2
Change zmake test to call zmake configure --test, unless the
--no-rebuild flag is used, in which case just run tests on existing
binaries. It is an error to use --no-rebuild, if you never did a zmake
build.
BRANCH=None
BUG=b:217788621
TEST=make clobber
zmake -j8 build herobrine test-drivers
zmake -j8 test --no-rebuild herobrine
zmake -j8 test --no-rebuild herobrine test-drivers
zmake -j8 test --no-rebuild herobrine test-drivers test-tasks
zmake -j8 build test-tasks
zmake -j8 test --no-rebuild herobrine test-drivers test-tasks
make clobber
zmake -j8 build --coverage herobrine test-drivers
zmake -j8 test --coverage --no-rebuild herobrine
zmake -j8 test --coverage --no-rebuild herobrine test-drivers
zmake -j8 test --coverage --no-rebuild herobrine test-drivers test-tasks
zmake -j8 build --coverage test-tasks
zmake -j8 test --coverage --no-rebuild herobrine test-drivers test-tasks
zmake -j8 test --coverage herobrine brya
zmake -j8 test --coverage --no-rebuild herobrine brya
zmake -j8 testall
zmake -j8 test --all
zmake -j8 test --all --no-rebuild
zmake -j8 test --host-tests-only
zmake -j8 test --host-tests-only --no-rebuild
zmake -j8 test --host-tests-only --coverage
zmake -j8 test --host-tests-only --coverage
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I90f23cd0061d97e42359e1d49f2331b71554e3a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3472683
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in go/zmake-cli-v2
Change zmake build to call zmake configure --build.
Updated docs to stop telling people to run both configure and build as
well as some other small documentation mistakes.
BRANCH=None
BUG=b:217788621
TEST=zmake -j8 build herobrine_npcx9
zmake -j8 build test-drivers
zmake -j8 build herobrine_npcx9 test-drivers
zmake -j8 build --all
zmake -j8 build --coverage herobrine_npcx9
zmake -j8 build --coverage test-drivers
zmake -j8 build --coverage herobrine_npcx9 test-drivers
zmake -j8 build --all --coverage
zmake test build/zephyr/test-drivers/
zmake test --coverage build/zephyr/test-drivers/
zmake -j8 configure --build herobrine_npcx9
zmake -j8 configure --build test-drivers
zmake -j8 configure --build herobrine_npcx9 test-drivers
zmake -j8 configure --build --all
zmake -j8 configure --build --coverage herobrine_npcx9
zmake -j8 configure --build --coverage test-drivers
zmake -j8 configure --build --coverage herobrine_npcx9 test-drivers
zmake -j8 configure --build --all --coverage
zmake -j8 configure --test herobrine_npcx9
zmake -j8 configure --test test-drivers
zmake -j8 configure --test herobrine_npcx9 test-drivers
zmake -j8 configure --test --all
zmake -j8 configure --test --coverage herobrine_npcx9
zmake -j8 configure --test --coverage test-drivers
zmake -j8 configure --test --coverage herobrine_npcx9 test-drivers
zmake -j8 configure --test --all --coverage
Cq-Depend: chromium:3470081
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iee939b92e39f0787e50234040a8b6b248ba6c831
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462631
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change zmake configure to work as described in go/zmake-cli-v2.
BRANCH=None
BUG=b:217788621
TEST=Various zmake configure cmds.
Cq-Include-Trybots: luci.chromeos.cq:cq-orchestrator
Cq-Depend: chromium:3462900
Change-Id: I58fa4d8427efff64c5764eac6ba4752a71785127
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445105
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NPCX9 is the only EC chip that will be used by herobrine, rename
the project from 'herobrine_npcx9' to 'herobrine'.
BRANCH=None
BUG=b:215771396
TEST=zmake configure -b herobrine
Cq-Depend: chrome-internal:4546687
Change-Id: I206a65f253ce38d1b263a13df6ace90c90a0e450
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459518
Reviewed-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract the coverage % from the lcov summary, so it shows up in the UI
at https://gitlab.com/zephyr-ec/ec/-/jobs.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id420e07b74ecbe646e79dbae4d53f01d2293e91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3443646
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When you zmake configure --test you get coverage output in
$build_dir/output/zephyr.info, but zmake configure --build didn't.
Change the latter to match.
Change CQ and gitlab builders to match this change.
BRANCH=None
BUG=b:156895937
TEST=Ran firmware_builder.py commands
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I38c71a6f711f05c89882084ac93fafdc1f8d0e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3436694
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up old unsupported Zephyr projects (asurada/hayato and
volteer/delbin)
BUG=b:217456313,b:217455790
TEST=zmake testall
BRANCH=none
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If08bb34ea48a246ea3f494b4cc4c0e237de3e11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3442485
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lcov was already being run with branch coverage, but include that in
the html reports also.
BRANCH=None
BUG=None
TEST=Ran commands locally
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia64d120ec13ef7e741ba78bc6d05621f1b045215
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3399900
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds npcx7/9_evb to the GitLab CI build test.
BUG=none
BRANCH=none
TEST=run on gitlab server
Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com>
Change-Id: I479293d7c77816a84cf2ef6d3e8dd36f41f010d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3392110
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you don't include --rc lcov_branch_coverage=1 on every lcov command,
lcov will drop the branch information at that stage of processing.
Add --rc lcov_branch_coverage=1 to all lcov commands.
BRANCH=None
BUG=None
TEST=None
Change-Id: I3fd2a036f9f2fcfaeec60bdc55cfcba28e6c8228
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381536
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Aaron Massey <aaronmassey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add builds and coverage builds for kingler, krabby, and skyrim.
BRANCH=None
BUG=None
TEST=for i in krabby kingler skyrim ; do \
zmake configure -b $i || echo FAIL; \
zmake configure -b --coverage $i || echo FAIL; done
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iab404a9d7b5d63f5382bbc60608821ee5262e93f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3363948
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add commands to the coverage_template to merge and filter the twister
coverage report with each board.
BRANCH=None
BUG=None
TEST=Pushed to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If58ffe10433c3f33618cdffd1b514ca0a514aa99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3367176
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loop over the merged commits from the upstream zephyr repo until we find
one that has a coverage report uploaded, and download that.
The coverage won't totally match up with the code we have checked out,
but it should be close, and this will save us many hours to re-run all
the tests.
BRANCH=None
BUG=None
TEST=Pushed manually to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I2d2c4462e94136ae5e521b1b212e914e7c302550
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3367175
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Project specific code can never be executed by our tests so filter it.
BRANCH=none
BUG=none
TEST=Check the filter pattern added by manually running the command
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I31f54b8bd1aa2d5e95529e790ee5d781228ae40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3352189
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In gitlab, single quotes are strong and do not resolve the
EC_DIR variable.
BRANCH=none
BUG=none
TEST=none, verified by reading the gitlab docs
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I4d30b146e909a5d03267f49ddc9feb60cc88cefb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3352188
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lcov needs absolute paths, or */dir patterns.
Change remove paths to be absolute.
BRANCH=None
BUG=None
TEST=Ran commands by hand
Change-Id: I4878fc429ff4dcd75684d51aa88971ed592c198f
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3330724
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tell zmake to search for the checkout path of the main branch (see the
dependencies) instead of the v2.7 checkout path.
Update the GitLab configuration to download main instead of
chromeos-v2.7.
BUG=b:205884929
BRANCH=none
TEST=zmake testall
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/420535963
Cq-Depend: chrome-internal:4299651
Change-Id: Ie7a2b7784606d0fc2455dab3c21ec3b49f073b06
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310534
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change `zmake configure --coverage --build` to only build the
all.libraries target (instead of failing as it does now), and generate
an lcov file.
Change `zmake coverage` to skip non-test projects. It hasn't actually
been useful to have a coverage report that includes all projects.
Change .gitlab-ci.yml commands from
build tests & boards coverage, merge, remove zephyr dirs, remove
non-board files, generate report
to build tests, merge, remove zephyr dirs, build board coverage, remove
zephyr dirs, merge with tests, remove non-board files, generate report.
This should increase coverage numbers, because we won't include #ifdefs
that both the board and tests don't use, but other boards do use. This
does not fix the problem of a test having an #ifdef that the board
doesn't have, but those should be smaller, and easier to fix.
Before: https://gitlab.com/zephyr-ec/ec/-/pipelines/420506965/builds
After: https://gitlab.com/zephyr-ec/ec/-/pipelines/420547936/builds
BRANCH=None
BUG=b:207689703
TEST=Pushed to gitlab coverage branch
Change-Id: Ifad0d098e5db9ef0ee55b760aaa7a8da9d006387
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310533
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|