| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The posix-ec project was renamed, and it was really only a sample, so
just remove it from here. The target zephyr_boards_coverage will still
build it, so we're not really losing anything by removing it.
BUG=b:237431976
BRANCH=none
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If7d006885b38fec97bd234bcb4b250bf74e4c6c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3736985
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gitlab builder is running out of disk space. Add flags to build
fewer things, and to delete the intermediate files and only leave the
output files.
Before this change zmake build of all boards took 2.1G, and 81M
afterwards.
BRANCH=None
BUG=None
TEST=make clobber
TEST=zmake build --boards-only -c --delete-intermediates
TEST=du -s -h build
Change-Id: I507abff512ca1348681a1fd7431d5267efaf5d65
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3726959
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that zmake defaults to the physical number of cpus, don't use -j8.
BRANCH=None
BUG=None
TEST=git cherrypick to gitlab
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If4049ed7a015680b35127b92c2fd49070c648d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3652378
Reviewed-by: Yuval Peress <peress@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new coverage report to the merged_coverage job, which is all
zephyr boards merged with EC and Zephyr tests (but not twister). This
will be a more useful report for tracking coverage increases or
regressions as it will include all boards not just herobrine.
BRANCH=None
BUG=None
TEST=Pushed to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id9c879ade22f7a53973bcea90b604250db92ddd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3652377
Reviewed-by: Yuval Peress <peress@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were filtering out some directories that are impossible to test with
coverage right now from the tests, but not from the boards.
Change filters to match in all 3 places.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I17ff82e277069ecddb7c61b61e9ba089a3c54cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3632182
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Volteer was the first reference board with EC based on Zephyr. At this
stage of migrating to Zephyr, the support for Volteer can be dropped, so
remove volteer project.
BUG=b:218888909
TEST=zmake testall
BRANCH=main
Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
Change-Id: Ie78cc69e478267f45446b9d11fc2f433136ebfe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521781
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In zmake, don't remove any directories from the coverage reports.
In gitlab, add the exclusions back in so that we get the same finished
html report that we got before.
BRANCH=None
BUG=b:156895937
TEST=Ran firmware_builder.py, verified zephyr/test & zephyr/emul
Ran .gitlab-ci.yml commands for herobrine and verified that
build/herobrine/output/filtered_no_zephyr.info is unchanged.
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie8fd1e787d8bb6e745f89d773113cccb6c335009
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491416
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables support for testing U-Boot vboot.
BUG=b:209799513
BRANCH=none
TEST=passes on gitlab:
https://gitlab.com/zephyr-ec/ec/-/pipelines/479753623
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I4a94ec7f08236a85b544f7eb73ce277993670af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3491075
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The regex wasn't matching the TOTAL line from the coverage report.
Change to the recommended regex from
https://docs.gitlab.com/ee/ci/pipelines/settings.html#test-coverage-examples
BRANCH=None
BUG=b:219062927
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia867148e95f0aa5de3a7e182a13cce952f4b114f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489261
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change all zmake invocations to use -j8, since it defaults to -j1, and
change the testall step to only build and run the tests.
BRANCH=None
BUG=b:217788621
TEST=None
Change-Id: Id8892ea5e37796da048573509cc17553dd8d0921
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488788
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new commands to run zmake unit tests with coverage enabled.
BRANCH=None
BUG=b:219062927
TEST=Ran commands in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ie7e8c0a33df8e92ff946e87bb787dd4a0aced2fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3472820
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in go/zmake-cli-v2
Change zmake test to call zmake configure --test, unless the
--no-rebuild flag is used, in which case just run tests on existing
binaries. It is an error to use --no-rebuild, if you never did a zmake
build.
BRANCH=None
BUG=b:217788621
TEST=make clobber
zmake -j8 build herobrine test-drivers
zmake -j8 test --no-rebuild herobrine
zmake -j8 test --no-rebuild herobrine test-drivers
zmake -j8 test --no-rebuild herobrine test-drivers test-tasks
zmake -j8 build test-tasks
zmake -j8 test --no-rebuild herobrine test-drivers test-tasks
make clobber
zmake -j8 build --coverage herobrine test-drivers
zmake -j8 test --coverage --no-rebuild herobrine
zmake -j8 test --coverage --no-rebuild herobrine test-drivers
zmake -j8 test --coverage --no-rebuild herobrine test-drivers test-tasks
zmake -j8 build --coverage test-tasks
zmake -j8 test --coverage --no-rebuild herobrine test-drivers test-tasks
zmake -j8 test --coverage herobrine brya
zmake -j8 test --coverage --no-rebuild herobrine brya
zmake -j8 testall
zmake -j8 test --all
zmake -j8 test --all --no-rebuild
zmake -j8 test --host-tests-only
zmake -j8 test --host-tests-only --no-rebuild
zmake -j8 test --host-tests-only --coverage
zmake -j8 test --host-tests-only --coverage
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I90f23cd0061d97e42359e1d49f2331b71554e3a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3472683
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in go/zmake-cli-v2
Change zmake build to call zmake configure --build.
Updated docs to stop telling people to run both configure and build as
well as some other small documentation mistakes.
BRANCH=None
BUG=b:217788621
TEST=zmake -j8 build herobrine_npcx9
zmake -j8 build test-drivers
zmake -j8 build herobrine_npcx9 test-drivers
zmake -j8 build --all
zmake -j8 build --coverage herobrine_npcx9
zmake -j8 build --coverage test-drivers
zmake -j8 build --coverage herobrine_npcx9 test-drivers
zmake -j8 build --all --coverage
zmake test build/zephyr/test-drivers/
zmake test --coverage build/zephyr/test-drivers/
zmake -j8 configure --build herobrine_npcx9
zmake -j8 configure --build test-drivers
zmake -j8 configure --build herobrine_npcx9 test-drivers
zmake -j8 configure --build --all
zmake -j8 configure --build --coverage herobrine_npcx9
zmake -j8 configure --build --coverage test-drivers
zmake -j8 configure --build --coverage herobrine_npcx9 test-drivers
zmake -j8 configure --build --all --coverage
zmake -j8 configure --test herobrine_npcx9
zmake -j8 configure --test test-drivers
zmake -j8 configure --test herobrine_npcx9 test-drivers
zmake -j8 configure --test --all
zmake -j8 configure --test --coverage herobrine_npcx9
zmake -j8 configure --test --coverage test-drivers
zmake -j8 configure --test --coverage herobrine_npcx9 test-drivers
zmake -j8 configure --test --all --coverage
Cq-Depend: chromium:3470081
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iee939b92e39f0787e50234040a8b6b248ba6c831
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3462631
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change zmake configure to work as described in go/zmake-cli-v2.
BRANCH=None
BUG=b:217788621
TEST=Various zmake configure cmds.
Cq-Include-Trybots: luci.chromeos.cq:cq-orchestrator
Cq-Depend: chromium:3462900
Change-Id: I58fa4d8427efff64c5764eac6ba4752a71785127
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445105
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NPCX9 is the only EC chip that will be used by herobrine, rename
the project from 'herobrine_npcx9' to 'herobrine'.
BRANCH=None
BUG=b:215771396
TEST=zmake configure -b herobrine
Cq-Depend: chrome-internal:4546687
Change-Id: I206a65f253ce38d1b263a13df6ace90c90a0e450
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3459518
Reviewed-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract the coverage % from the lcov summary, so it shows up in the UI
at https://gitlab.com/zephyr-ec/ec/-/jobs.
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id420e07b74ecbe646e79dbae4d53f01d2293e91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3443646
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When you zmake configure --test you get coverage output in
$build_dir/output/zephyr.info, but zmake configure --build didn't.
Change the latter to match.
Change CQ and gitlab builders to match this change.
BRANCH=None
BUG=b:156895937
TEST=Ran firmware_builder.py commands
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I38c71a6f711f05c89882084ac93fafdc1f8d0e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3436694
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up old unsupported Zephyr projects (asurada/hayato and
volteer/delbin)
BUG=b:217456313,b:217455790
TEST=zmake testall
BRANCH=none
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If08bb34ea48a246ea3f494b4cc4c0e237de3e11b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3442485
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lcov was already being run with branch coverage, but include that in
the html reports also.
BRANCH=None
BUG=None
TEST=Ran commands locally
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia64d120ec13ef7e741ba78bc6d05621f1b045215
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3399900
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds npcx7/9_evb to the GitLab CI build test.
BUG=none
BRANCH=none
TEST=run on gitlab server
Signed-off-by: Wealian Liao <whliao@nuvoton.corp-partner.google.com>
Change-Id: I479293d7c77816a84cf2ef6d3e8dd36f41f010d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3392110
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you don't include --rc lcov_branch_coverage=1 on every lcov command,
lcov will drop the branch information at that stage of processing.
Add --rc lcov_branch_coverage=1 to all lcov commands.
BRANCH=None
BUG=None
TEST=None
Change-Id: I3fd2a036f9f2fcfaeec60bdc55cfcba28e6c8228
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3381536
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Commit-Queue: Aaron Massey <aaronmassey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add builds and coverage builds for kingler, krabby, and skyrim.
BRANCH=None
BUG=None
TEST=for i in krabby kingler skyrim ; do \
zmake configure -b $i || echo FAIL; \
zmake configure -b --coverage $i || echo FAIL; done
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iab404a9d7b5d63f5382bbc60608821ee5262e93f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3363948
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add commands to the coverage_template to merge and filter the twister
coverage report with each board.
BRANCH=None
BUG=None
TEST=Pushed to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: If58ffe10433c3f33618cdffd1b514ca0a514aa99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3367176
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loop over the merged commits from the upstream zephyr repo until we find
one that has a coverage report uploaded, and download that.
The coverage won't totally match up with the code we have checked out,
but it should be close, and this will save us many hours to re-run all
the tests.
BRANCH=None
BUG=None
TEST=Pushed manually to gitlab coverage branch
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I2d2c4462e94136ae5e521b1b212e914e7c302550
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3367175
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Project specific code can never be executed by our tests so filter it.
BRANCH=none
BUG=none
TEST=Check the filter pattern added by manually running the command
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I31f54b8bd1aa2d5e95529e790ee5d781228ae40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3352189
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In gitlab, single quotes are strong and do not resolve the
EC_DIR variable.
BRANCH=none
BUG=none
TEST=none, verified by reading the gitlab docs
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I4d30b146e909a5d03267f49ddc9feb60cc88cefb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3352188
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lcov needs absolute paths, or */dir patterns.
Change remove paths to be absolute.
BRANCH=None
BUG=None
TEST=Ran commands by hand
Change-Id: I4878fc429ff4dcd75684d51aa88971ed592c198f
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3330724
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tell zmake to search for the checkout path of the main branch (see the
dependencies) instead of the v2.7 checkout path.
Update the GitLab configuration to download main instead of
chromeos-v2.7.
BUG=b:205884929
BRANCH=none
TEST=zmake testall
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/420535963
Cq-Depend: chrome-internal:4299651
Change-Id: Ie7a2b7784606d0fc2455dab3c21ec3b49f073b06
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310534
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change `zmake configure --coverage --build` to only build the
all.libraries target (instead of failing as it does now), and generate
an lcov file.
Change `zmake coverage` to skip non-test projects. It hasn't actually
been useful to have a coverage report that includes all projects.
Change .gitlab-ci.yml commands from
build tests & boards coverage, merge, remove zephyr dirs, remove
non-board files, generate report
to build tests, merge, remove zephyr dirs, build board coverage, remove
zephyr dirs, merge with tests, remove non-board files, generate report.
This should increase coverage numbers, because we won't include #ifdefs
that both the board and tests don't use, but other boards do use. This
does not fix the problem of a test having an #ifdef that the board
doesn't have, but those should be smaller, and easier to fix.
Before: https://gitlab.com/zephyr-ec/ec/-/pipelines/420506965/builds
After: https://gitlab.com/zephyr-ec/ec/-/pipelines/420547936/builds
BRANCH=None
BUG=b:207689703
TEST=Pushed to gitlab coverage branch
Change-Id: Ifad0d098e5db9ef0ee55b760aaa7a8da9d006387
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3310533
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're not running these in a QEMU we'll never be able to touch
these files.
BRANCH=none
BUG=none
TEST=Run zmake with coverage and manually run lcov with the filters
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I7815dfedafaaacad160408fec7618c89e457d280
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3291128
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like * in lcov isn't recusive. Use ** instead which does the
job correctly. Also, include the matching include/ directory which
I missed on the first pass.
BRANCH=none
BUG=none
TEST=Run tests with coverage, then manually run lcov and verify that
the directory was removed.
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I7eb58b0eff01ecd5ba9c4f5da18e947d3e41c489
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3291127
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This drops all support for projects to specify which zephyr version
they use. Zmake no longer cares what Zephyr version you give it: it
will simply use whatever's passed for --zephyr-base and be happy with
it.
This intentionally hard-codes the checkout path to the v2.7 branch as
the Zephyr version used to de-couple from the cutover to the main
branch. The follow up CL actually switches to the main branch. (This
is, more or less, just self-contained preparatory work in zmake for the
transition to main.)
BUG=b:205884929
BRANCH=none
TEST=unit tests pass
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/412252730
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I9f8e28cec6466c666862c8f46f1608625a3ec53f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3296530
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate a coverage report for hayato also.
BRANCH=None
BUG=None
TEST=None
Change-Id: Ic789460166282f3ad631aa0091e81eddc84a08db
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289292
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the drivers written under zephyr/drivers/ from the code coverage.
These drivers are in the process of being migrated upstream and the tests
will be done upstream as well. Additionally, adding emulators to support
this in a host test will be too difficult since many dependencies in
the Zephyr build are SOC and SOC_FAMILY dependent.
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Yuval Peress <peress@google.com>
Change-Id: I27bcc31e5ee474aff2be050b8ef8289a1512b6cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3288905
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch the GitLab CI runner to use project name, instead of manually
specifying the directory. This is so that projects can specify more
than one project per directory.
BUG=b:193815337
BRANCH=none
TEST=https://gitlab.com/zephyr-ec/ec/-/pipelines/410231302
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I7a32f3be069b388741ef65af2374a5dfae22e86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3286371
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For context: this build was created so that we had a device that could
be publicly purchased to play with Zephyr on in January 2021. With a
little passage of time, we now have lazor, limozeen, and delbin as
well.
This build supports nothing other than power sequence to S0 (no
keyboard, battery, charging, etc.) so sadly it's hardly usable for
anything at the moment. Delete it so it does not create confusing
directory structure for how we want variants to be created.
BUG=b:193814903
BRANCH=none
TEST=zmake testall
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: Ic0fa3099c19a484513b23c7826376604cf8d2f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3271872
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Install the pyyaml package, it was required by zmake, and installed by pip when you installed zmake.
Now it is still needed, but not discovered by pip, so it needs to be installed explicitly.
See https://gitlab.com/zephyr-ec/ec/-/jobs/1737467792
BRANCH=None
BUG=b:193815337
TEST=Build locally in docker
Change-Id: Ie467b3f1ddc338b387c6ccae1f202c52734e55e2
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3257867
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Yuval Peress <peress@google.com>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a recent breakage where one job failed because of a git clone
timeout. But more importantly, we should make sure all the jobs are
using the same commit.
Change CI jobs to use the gitlab cache to keep the non-ec git repos so
only the first job (seed_cache) will do the git clone, and the others
will just pull the files from the cache.
The cache key is the ec commit sha that is being built.
The total build time after this is 40m, and the builds before this were
37-39m, so it doesn't seem to be a change.
BUG=None
BRANCH=None
TEST=Pushed to coverage branch on gitlab:
https://gitlab.com/zephyr-ec/ec/-/pipelines/382237078
Change-Id: Ic596464fbf90c2964075b4f8f3e6bdc77bde531b
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3205632
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow us to build coverage reports for multiple boards.
Also add the `coverage` keyword, so the coverage of each step will
appear on the jobs page. I.e.
https://gitlab.com/zephyr-ec/ec/-/pipelines/380049325/builds
BRANCH=None
BUG=None
TEST=None
Change-Id: I892653406f471b3c98ad6dbd7cb91c086614e264
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197731
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved the zephyr directory, and didn't update the exclusion in
merged_coverage.
BRANCH=None
BUG=None
TEST=None
Change-Id: I23532af4c95d547343aa25aa6fd39174fe58ee68
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3197730
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Aaron Massey <aaronmassey@google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checkout all zephyr versions on gitlab, and pass the root directory to
zmake instead of just 1 version.
BUG=None
TEST=sudo emerge zephyr-build-tools && \
./zephyr/firmware_builder.py --metrics /tmp/tmpwhi95jy2 build && \
./zephyr/zmake/run_tests.sh
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I6016495aeff847b2cba081e1fa8731526de11f8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3194982
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch to updated docker container.
Make shallow git clones for speed.
Don't install anytree or pyelftools, since they are in the docker
container now.
Set explicit `needs` attributes on each job.
Split coverage build into ec_coverage, zephyr_coverage, and
merged_coverage.
Run make -j8 instead of make -j.
Run make test-coverage instead of make coverage. For this situation we
don't need the base board coverage, nor the report.
Stop using flock to prevent parallel calls to lcov. I don't know if it
was ever unsafe, but it seems safe today.
BUG=None
BRANCH=None
TEST=Pushed to gitlab coverage branch:
https://gitlab.com/zephyr-ec/ec/-/pipelines/379672379
Change-Id: I90ed7bb947d96062042959aee957bc6728c22ea7
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3194977
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crrev/c/3173097 broke the yaml file. Quote the "SF:" text to avoid yaml
parser issues.
BUG=None
TEST=Used the CI lint tool: https://gitlab.com/zephyr-ec/ec/-/ci/lint
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I53e1cbee7bb73f31f205e55718367ee3bebe2bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3188642
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the coverage artifacts, build a report for herobrine w/o
zephyr code.
BUG=None
BRANCH=None
TEST=Ran cmds in docker
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I7b1291d4d447769487870fc701a8452aeaffa649
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3173097
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build both the zephyr and the cros-ec coverage reports, and merge the
info files.
BRANCH=None
BUG=None
TEST=Ran cmds in docker.
Change-Id: I22e8c1e6192ba4b917fc5a5ee434dfb4edcb866d
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3173096
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Yuval Peress <peress@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add herobrine_npcx9 to gitlab CI script.
BUG=None
TEST=None
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Id02bd7dc5a64b94c973636db1869bc9e2588dfc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163116
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crrev/c/3149344 made nanopb required, so fetch it before building.
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I1d38e2d4e1208bfbccdd04a32d9c11ba0841d5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163117
Reviewed-by: Yuval Peress <peress@google.com>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is some garbage ninja messages at the top of the txt versions of
the reports, but the json reports are good.
BUG=None
TEST=Ran cmds in docker
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Iac287da55beef7e0896d37416fd9ae943c48eaeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3160502
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should run all tests on gitlab, that could have caught the breakage
of accel_cal much sooner.
BUG=None
TEST=Pushed to gitlab coverage branch
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I72ba56361b9c796df770ceee7965bd674d9378a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3139096
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new coverage job to gitlab.
BUG=None
TEST=Pushed to gitlab coverage branch
BRANCH=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I2dd20ee94934b71426e00e8d45b2670f106048ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3119210
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|